Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLDSA zeroization and debug scan assertions #744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ekarabu
Copy link
Contributor

@ekarabu ekarabu commented Feb 21, 2025

Expanded Zeroization Assertions:

  1. Added SVA checks to verify that rho_p_reg, privatekey_reg, seed_reg, entropy_reg, and sign_rnd_reg are completely cleared when MLDSA_ZEROIZATION or MLDSA_SCAN_DEBUG is asserted.
  2. Memory Interface Zeroization Assertions: Included assertions for skencode_mem_rd_data, skencode_wr_data, skdecode_mem_wr_data, skdecode_rd_data, and mldsa_mem_rdata0_bank to confirm zeroization. Checks for mldsa_mem_wdata and mldsa_mem_wdata0_bank to guarantee secure memory clearing.
  3. Private Key Memory Zeroization Checks: Introduced word-by-word assertions for MLDSA private key memory banks to confirm that memory is wiped upon zeroize_mem_done assertion.

Waits for chipsalliance/adams-bridge#102

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/integration/asserts/caliptra_top_sva.sv: Language not supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to revert this change since it points to older commits. the daily branch has the most updated ABR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants