Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caliptra API Enhancements :Part-2 #1713

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Caliptra API Enhancements :Part-2 #1713

merged 1 commit into from
Oct 30, 2024

Conversation

rusty1968
Copy link
Contributor

@rusty1968 rusty1968 commented Oct 10, 2024 •
edited
Loading

  • Add documentation showing how to use the SocManager trait.
  • Update SocManager with new trait methods.

@rusty1968 rusty1968 force-pushed the caliptra-api-enhancement-part2 branch 7 times, most recently from bebe7af to 0deffe8 Compare October 15, 2024 00:39
@rusty1968 rusty1968 marked this pull request as ready for review October 15, 2024 00:43
@rusty1968 rusty1968 force-pushed the caliptra-api-enhancement-part2 branch 2 times, most recently from c9a6b3d to c14889a Compare October 15, 2024 00:58
zhalvorsen
zhalvorsen reviewed Oct 22, 2024
View reviewed changes
@rusty1968 rusty1968 force-pushed the caliptra-api-enhancement-part2 branch 4 times, most recently from 63774bc to 707e214 Compare October 22, 2024 23:53
@rusty1968 rusty1968 force-pushed the caliptra-api-enhancement-part2 branch from 707e214 to 2b5050c Compare October 23, 2024 16:50
@rusty1968
Caliptra API Enhancements :
f367943 
- Add documentation showing how to use the SocManager trait.
- Address feedback from the last review.
- Update SocManager with new trait methods.
@rusty1968 rusty1968 force-pushed the caliptra-api-enhancement-part2 branch from 2b5050c to f367943 Compare October 23, 2024 17:47
swenson
swenson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnTraverAmd JohnTraverAmd merged commit 613df2b into chipsalliance:main Oct 30, 2024
11 checks passed
mhatrevi pushed a commit that referenced this pull request Nov 18, 2024
@rusty1968 @mhatrevi
Caliptra API Enhancements : (#1713)
e8ce0b9 
- Add documentation showing how to use the SocManager trait.
- Address feedback from the last review.
- Update SocManager with new trait methods.

(cherry picked from commit 613df2b)
mhatrevi pushed a commit that referenced this pull request Nov 19, 2024
@rusty1968 @mhatrevi
Caliptra API Enhancements : (#1713)
bfd9bf5 
- Add documentation showing how to use the SocManager trait.
- Address feedback from the last review.
- Update SocManager with new trait methods.

(cherry picked from commit 613df2b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@korran korran korran approved these changes

@zhalvorsen zhalvorsen zhalvorsen approved these changes

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@jlmahowa-amd jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rusty1968 @swenson @korran @zhalvorsen @JohnTraverAmd