Refactor common runtime tests so new parameters to run_rt_test do not require updating every test using it #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
swenson and
vsonims
as code owners
clundin25
changed the title
clundin25
force-pushed
the
refactor-runtime-tests
branch
from
ab4cb4c to
6dbdecd
Compare
jhand2
force-pushed
the
refactor-runtime-tests
branch
from
6dbdecd to
bd06b44
Compare
jhand2
approved these changes
Nov 6, 2024
… require updating every test using it.
jhand2
force-pushed
the
refactor-runtime-tests
branch
from
bd06b44 to
d8d88b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce the size of #1732.
Wrapping the arguments to
run_rt_testreduces how many locations need to be updated if a new argument is introduced.