Release artifacts for main-2.x #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
from
f7a60ea to
7e82d86
Compare
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
10 times, most recently
from
971945d to
79ec0b0
Compare
nquarton
reviewed
Feb 13, 2025
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
from
79ec0b0 to
d161567
Compare
nquarton
reviewed
Feb 20, 2025
There was a problem hiding this comment.
I don't think this should be added to the existing nightly release. That would mean the two are dependent on each other and releases can't be made independently. I understand it may need to go in main so it can be scheduled, but if so, I think it should be a separate action.
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
from
d161567 to
0571b5c
Compare
I put it in a different file. |
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
from
0571b5c to
c1d83b5
Compare
Scheduled actions can only be done on the main branch, which is why a workflow_dispatch is used. Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
ArthurHeymans
force-pushed
the
ReleaseArtefacts
branch
from
c1d83b5 to
0a9ede4
Compare
|
I tried the CI workflow and it seems to work. |
nquarton
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create releases for the main-2.x branch. Currently only sw-emulator artifacts get generated.