Cherry-pick for main-2.x: Update zerocopy from 0.6.6 to 0.8.8. #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
vsonims,
rusty1968,
bluegate010,
FerralCoder,
ajisaxena and
JohnTraverAmd
as code owners
swenson
force-pushed
the
zerocopy-2.x
branch
2 times, most recently
from
79b5081 to
0242344
Compare
jhand2
previously approved these changes
Feb 10, 2025
|
(After speaking with @mhatrevi, I think he is going to prepare a PR cherry-picking everything up to this from the 1.x branch, which we will merge first. That way, history will be more or less linear.) |
clundin25
previously approved these changes
Feb 10, 2025
|
So #1956 would require this in order to update caliptra-dpe which already uses 0.8.8 |
SGTM. So should we abandon this one? |
|
@jhand2 I don't think we need to abandon this one. I'll just rebase it once Vishal gets that other PR in. |
swenson
force-pushed
the
zerocopy-2.x
branch
from
0242344 to
c532995
Compare
|
Rebased and should be good to go now. |
This PR does not optimize out a large portion of copies. Ideally it will be done in follow up PRs. There are portions of code that are slightly modified to keep panics out of the final binary.
swenson
force-pushed
the
zerocopy-2.x
branch
from
c532995 to
d65fe45
Compare
swenson
force-pushed
the
zerocopy-2.x
branch
from
d65fe45 to
621f273
Compare
mhatrevi
previously approved these changes
Feb 12, 2025
jhand2
approved these changes
Feb 12, 2025
mhatrevi
approved these changes
Feb 12, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #1765 along with fixups for the new functionality in 2.x.
Original description:
Update zerocopy from 0.6.6 to 0.8.8.
This PR does not optimize out a large portion of copies. Ideally it will
be done in follow up PRs.
There are portions of code that are slightly modified to keep panics out
of the final binary.