Update to rust 1.84 #1956
Update to rust 1.84 #1956
Conversation
ArthurHeymans
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
rusty1968,
bluegate010,
FerralCoder,
ajisaxena and
JohnTraverAmd
as code owners
ArthurHeymans
force-pushed
the
rust-1.84
branch
from
5cd5f89 to
1cb6526
Compare
|
It fails formatting on DPE. Main branch of DPE seems to have that fixed, however it would require chipsalliance/caliptra-dpe#388 to be cherry-picked |
ArthurHeymans
force-pushed
the
rust-1.84
branch
2 times, most recently
from
667454b to
39cdca2
Compare
|
So the ubuntu 20.04 linker seems to have problems with the libcaliptra.a and fails to find some symbols. This does not happen on my local machine. Trying out more recent images in CI (20.04 is deprecated soon anyway) |
ArthurHeymans
force-pushed
the
rust-1.84
branch
from
696d787 to
3375383
Compare
|
@ArthurHeymans The symbols dropping appear to be due to them only accidentally being included in the first place -- they weren't actually defined except in test modes. I'm not sure how the code ever compiled. So, I added those symbols into the C code properly. I also fixed an additional problem where the Go code was passing in a nil slice with 0 length, which was previously allowed but now panics. |
ArthurHeymans
force-pushed
the
rust-1.84
branch
3 times, most recently
from
5a81673 to
8f7e932
Compare
This fixes all the warnings and erros that the newer rust toolchain throws. 1.84 uses a bit more stack than 1.70. Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
It looks like linker has problems. Maybe updating fixes it? Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
caliptra_model.h is not a file. Update the target to be an actual file. Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
Frankly, I don't know how the code was compiling before, but I suppose Rust must have either accidentally left the symbols in the `.a` file? Also we need to pass non-nil ICCM and DCCM pointers in Go code to Rust, as Rust now will panic if nil slices are constructed, even if they have length 0.
The reason for doing this is to be able to generate templates using rustcrypto which already supports ML-DSA87 (needs 1.81).
This PR fixes all the warnings and errors that the new toolchain brings.
Stack usage is increase by 4K with this newer version