Refactor publishing logic (#4901)

mill-ci-release is archived and we were accidentally publishing the
compiler plugin for Scala 3.

Author: jackkoenig

.github/workflows/ci.yml

@@ -85,7 +85,7 @@ jobs:
         with:
           jvm: temurin:11
       - name: Publish
-        run: ./mill -i io.kipp.mill.ci.release.ReleaseModule/publishAll
+        run: ./mill publish.publishAll
         env:
           PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
           PGP_SECRET: ${{ secrets.PGP_SECRET }}

build.mill

@@ -1,8 +1,10 @@
 package build
 
 import mill._
+import mill.api.Result
 import mill.scalalib._
 import mill.scalalib.scalafmt._
+import mill.scalalib.publish.{Artifact, SonatypePublisher}
 
 import $packages._
 import build._
@@ -59,6 +61,10 @@ object v extends Module {
     }
   }
 
+  // Projects that we publish to Maven
+  def publishedProjects: Seq[PublishModule] =
+    pluginScalaCrossVersions.filterNot(isScala3).map(plugin.cross(_)) ++ Seq(unipublish)
+
   val scalaVersion = scalaCrossVersions.head
   val jmhVersion = "1.37"
   val osLib = ivy"com.lihaoyi::os-lib:0.10.0"
@@ -317,3 +323,66 @@ trait Chisel extends CrossSbtModule with HasScala2MacroAnno with HasScalaPlugin
 }
 
 object unipublish extends release.Unipublish
+
+/** Tasks for publishing to Sonatype */
+object publish extends Module {
+
+  def getEnvVar(name: String) = Task.Command {
+    Task.env.get(name) match {
+      case Some(value) => Result.Success(value)
+      case None        => Result.Failure(s"Must define environment variable $name")
+    }
+  }
+
+  def sonatypeCredentials: Task[String] = Task.Anon {
+    val username = getEnvVar("SONATYPE_USERNAME")()
+    val password = getEnvVar("SONATYPE_PASSWORD")()
+    s"$username:$password"
+  }
+
+  def importPgp = Task.Anon {
+    val secret = getEnvVar("PGP_SECRET")()
+    os.call(
+      ("gpg", "--import", "--no-tty", "--batch", "--yes"),
+      stdin = java.util.Base64.getDecoder.decode(secret)
+    )
+  }
+
+  // We can't directly use mill.scalalib.PublishModule.publishAll because
+  // there's no easy way to programmatically pick which PublishModules to
+  // publish, and we don't want to publish everything.
+  // We aren't yet publishing Scala 3 cross-builds nor the CIRCT bindings.
+  def publishAll(): Command[Unit] = Task.Command {
+    val sonatypeUrl = "https://s01.oss.sonatype.org/service/local"
+    val sonatypeSnapshotUrl = "https://s01.oss.sonatype.org/content/repositories/snapshots"
+
+    val artifacts: Seq[(Seq[(os.Path, String)], Artifact)] =
+      Task.traverse(v.publishedProjects)(_.publishArtifacts)().map { case PublishModule.PublishData(a, s) =>
+        (s.map { case (p, f) => (p.path, f) }, a)
+      }
+
+    val sonatypeCreds = sonatypeCredentials()
+    // Import GPG, this is mutating the environment
+    importPgp()
+    val pgpPass = getEnvVar("PGP_PASSPHRASE")()
+    val gpgArgs = PublishModule.defaultGpgArgsForPassphrase(Some(pgpPass))
+
+    new SonatypePublisher(
+      sonatypeUrl,
+      sonatypeSnapshotUrl,
+      sonatypeCreds,
+      signed = true,
+      gpgArgs,
+      readTimeout = 10 * 60 * 1000,
+      connectTimeout = 10 * 1000,
+      Task.log,
+      Task.workspace,
+      Task.env,
+      awaitTimeout = 10 * 60 * 1000,
+      stagingRelease = true
+    ).publishAll(
+      release = false, // We like to confirm in the Sonatype UI
+      artifacts: _*
+    )
+  }
+}

circtpanamabinding/package.mill

@@ -11,7 +11,7 @@ object `package` extends RootModule with CIRCTPanamaBinding
 
 // Java Codegen for all declared functions.
 // All of these functions are not private API which is subject to change.
-trait CIRCTPanamaBinding extends HasJextractGeneratedSources with release.BaseChiselPublishModule {
+trait CIRCTPanamaBinding extends HasJextractGeneratedSources with release.ChiselPublishModule {
   override def javadocOptions = Task(super.javadocOptions() ++ Seq("--enable-preview", "--release", "21"))
 
   object utils extends Module {

panamaconverter/package.mill

@@ -19,7 +19,7 @@ trait PanamaConverter
     with CrossModuleBase
     with HasScalaPlugin
     with ScalafmtModule
-    with release.BaseChiselPublishModule {
+    with release.ChiselPublishModule {
   def millSourcePath = super.millSourcePath / os.up
 
   def panamaOMModule = panamaom.cross(crossScalaVersion)

panamalib/package.mill

@@ -19,7 +19,7 @@ trait PanamaLib
     with HasCIRCTPanamaBindingModule
     with CrossModuleBase
     with ScalafmtModule
-    with release.BaseChiselPublishModule {
+    with release.ChiselPublishModule {
   def millSourcePath = super.millSourcePath / os.up
 
   def circtPanamaBindingModule = circtpanamabinding

panamaom/package.mill

@@ -18,7 +18,7 @@ trait PanamaOM
     with HasPanamaLibModule
     with CrossModuleBase
     with ScalafmtModule
-    with release.BaseChiselPublishModule {
+    with release.ChiselPublishModule {
   def millSourcePath = super.millSourcePath / os.up
 
   def panamaLibModule = panamalib.cross(crossScalaVersion)

release.mill

@@ -7,14 +7,14 @@ import mill.scalalib.publish._
 import mill.api.Result
 import mill.scalalib.api.ZincWorkerUtil.matchingVersions
 import mill.util.Jvm.createJar
-import $ivy.`io.chris-kipp::mill-ci-release_mill0.12:0.2.1` // https://github.com/ckipp01/mill-ci-release/pull/143
-import io.kipp.mill.ci.release.{CiReleaseModule, SonatypeHost}
-import de.tobiasroeser.mill.vcs.version.VcsVersion // pulled in by mill-ci-release
+
+import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version::0.4.1`
+import de.tobiasroeser.mill.vcs.version.VcsVersion
 
 import build._
 
 /** Adds basic publishing information--useful for local publishing */
-trait BaseChiselPublishModule extends PublishModule {
+trait ChiselPublishModule extends PublishModule {
   // Publish information
   def pomSettings = PomSettings(
     description = artifactName(),
@@ -38,11 +38,6 @@ trait BaseChiselPublishModule extends PublishModule {
     )
 }
 
-/** Integrates the Module into the Chisel CI publishing flow */
-trait ChiselPublishModule extends CiReleaseModule with BaseChiselPublishModule {
-  override def sonatypeHost = Some(SonatypeHost.s01)
-}
-
 /** Aggregate project for publishing Chisel as a single artifact
   */
 trait Unipublish extends ScalaModule with ChiselPublishModule {