Delete many old deprecated APIs (#3733)

Author: jackkoenig

core/src/main/scala/chisel3/Aggregate.scala

@@ -9,7 +9,7 @@ import scala.collection.immutable.{SeqMap, VectorMap}
 import scala.collection.mutable.{HashSet, LinkedHashMap}
 import scala.language.experimental.macros
 import chisel3.experimental.{BaseModule, BundleLiteralException, HasTypeAlias, OpaqueType, VecLiteralException}
-import chisel3.experimental.{SourceInfo, UnlocatableSourceInfo}
+import chisel3.experimental.{requireIsChiselType, requireIsHardware, SourceInfo, UnlocatableSourceInfo}
 import chisel3.internal._
 import chisel3.internal.Builder.pushCommand
 import chisel3.internal.firrtl.ir._
@@ -1324,16 +1324,6 @@ package experimental {
   class BundleLiteralException(message: String) extends chisel3.ChiselException(message)
   class VecLiteralException(message: String) extends chisel3.ChiselException(message)
 
-  /** Indicates that the compiler plugin should generate [[cloneType]] for this type
-    *
-    * All user-defined [[Record]]s should mix this trait in as it will be required for upgrading to Chisel 3.6.
-    */
-  @deprecated("AutoCloneType is now always enabled, no need to mix it in", "Chisel 3.6")
-  trait AutoCloneType { self: Record =>
-
-    override def cloneType: this.type = _cloneTypeImpl.asInstanceOf[this.type]
-
-  }
 }
 
 /** Base class for data types defined as a bundle of other data types.

core/src/main/scala/chisel3/Const.scala

@@ -3,8 +3,8 @@
 package chisel3
 
 import chisel3._
-import chisel3.internal.{requireIsChiselType, requireNoProbeTypeModifier, Builder}
-import chisel3.experimental.SourceInfo
+import chisel3.internal.{requireNoProbeTypeModifier, Builder}
+import chisel3.experimental.{requireIsChiselType, SourceInfo}
 
 /** Create a constant type in FIRRTL, which is guaranteed to take a single
   * constant value.

core/src/main/scala/chisel3/Data.scala

@@ -5,7 +5,7 @@ package chisel3
 import chisel3.experimental.dataview.reify
 
 import scala.language.experimental.macros
-import chisel3.experimental.{Analog, BaseModule}
+import chisel3.experimental.{requireIsChiselType, requireIsHardware, Analog, BaseModule}
 import chisel3.experimental.{prefix, SourceInfo, UnlocatableSourceInfo}
 import chisel3.experimental.dataview.reifySingleData
 import chisel3.internal.Builder.pushCommand

core/src/main/scala/chisel3/IO.scala

@@ -1,8 +1,7 @@
 package chisel3
 
-import chisel3.internal.requireIsChiselType // Fix ambiguous import
 import chisel3.internal.{throwException, Builder}
-import chisel3.experimental.{noPrefix, SourceInfo}
+import chisel3.experimental.{noPrefix, requireIsChiselType, SourceInfo}
 import chisel3.properties.{Class, Property}
 import chisel3.reflect.DataMirror.internal.chiselTypeClone
 

core/src/main/scala/chisel3/Mem.scala

@@ -10,7 +10,7 @@ import chisel3.internal._
 import chisel3.internal.Builder.pushCommand
 import chisel3.internal.firrtl.ir._
 import chisel3.internal.sourceinfo.{MemTransform, SourceInfoTransform}
-import chisel3.experimental.{SourceInfo, SourceLine}
+import chisel3.experimental.{requireIsChiselType, requireIsHardware, SourceInfo, SourceLine}
 
 object Mem {
 

core/src/main/scala/chisel3/Module.scala

@@ -9,7 +9,7 @@ import scala.language.experimental.macros
 import chisel3.internal._
 import chisel3.internal.Builder._
 import chisel3.internal.firrtl.ir._
-import chisel3.experimental.{BaseModule, SourceInfo, UnlocatableSourceInfo}
+import chisel3.experimental.{requireIsChiselType, BaseModule, SourceInfo, UnlocatableSourceInfo}
 import chisel3.internal.sourceinfo.{InstTransform}
 import chisel3.properties.{Class, Property}
 import chisel3.reflect.DataMirror
@@ -719,7 +719,7 @@ package experimental {
     // data must be a fresh Chisel type
     private[chisel3] def createSecretIO[A <: Data](data: => A)(implicit sourceInfo: SourceInfo): A = {
       val iodef = data
-      internal.requireIsChiselType(iodef, "io type")
+      requireIsChiselType(iodef, "io type")
       require(!isFullyClosed, "Cannot create secret ports if module is fully closed")
 
       Module.assignCompatDir(iodef)

core/src/main/scala/chisel3/Reg.scala

@@ -7,7 +7,7 @@ import scala.language.experimental.macros
 import chisel3.internal._
 import chisel3.internal.Builder.pushCommand
 import chisel3.internal.firrtl.ir._
-import chisel3.experimental.SourceInfo
+import chisel3.experimental.{requireIsChiselType, requireIsHardware, SourceInfo}
 import chisel3.internal.sourceinfo.SourceInfoTransform
 
 /** Utility for constructing hardware registers

core/src/main/scala/chisel3/experimental/dataview/package.scala

@@ -37,17 +37,6 @@ package object dataview {
     }
   }
 
-  /** Provides `viewAsSupertype` for subclasses of [[Bundle]] */
-  @deprecated("Use RecordUpcastable instead", "chisel3.6")
-  implicit class BundleUpcastable[T <: Bundle](target: T) {
-
-    /** View a [[Bundle]] or [[Record]] as a parent type (upcast) */
-    def viewAsSupertype[V <: Bundle](proto: V)(implicit ev: ChiselSubtypeOf[T, V], sourceInfo: SourceInfo): V = {
-      implicit val dataView = PartialDataView.supertype[T, V](_ => proto)
-      target.viewAs[V]
-    }
-  }
-
   /** Provides `viewAsSupertype` for subclasses of [[Record]] */
   implicit class RecordUpcastable[T <: Record](target: T) {
 

core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala

@@ -61,7 +61,7 @@ object Lookupable {
   )(
     implicit sourceInfo: SourceInfo
   ): T = {
-    internal.requireIsHardware(data, "cross module reference type")
+    experimental.requireIsHardware(data, "cross module reference type")
     data._parent match {
       case None => data
       case Some(parent) =>

core/src/main/scala/chisel3/experimental/package.scala

@@ -21,13 +21,6 @@ package object experimental {
   implicit def fromDoubleToDoubleParam(x: Double): DoubleParam = DoubleParam(x)
   implicit def fromStringToStringParam(x: String): StringParam = StringParam(x)
 
-  @deprecated("This type has moved to chisel3", "Chisel 3.5")
-  type ChiselEnum = chisel3.ChiselEnum
-  @deprecated("This type has moved to chisel3", "Chisel 3.5")
-  type EnumType = chisel3.EnumType
-  @deprecated("This type has moved to chisel3", "Chisel 3.5")
-  val suppressEnumCastWarning = chisel3.suppressEnumCastWarning
-
   // Rocket Chip-style clonemodule
 
   /** A record containing the results of CloneModuleAsRecord
@@ -488,7 +481,4 @@ package object experimental {
       "_10" -> _10
     )
   }
-
-  @deprecated("This value has moved to chisel3.reflect", "Chisel 3.6")
-  val DataMirror = chisel3.reflect.DataMirror
 }

core/src/main/scala/chisel3/internal/Binding.scala

@@ -9,16 +9,6 @@ import chisel3.properties.Class
 
 import scala.collection.immutable.VectorMap
 
-@deprecated(deprecatedPublicAPIMsg + ". Use chisel3.experimental.requireIsHardware instead", "Chisel 3.6")
-object requireIsHardware {
-  def apply(node: Data, msg: String = ""): Unit = chisel3.experimental.requireIsHardware.apply(node, msg)
-}
-
-@deprecated(deprecatedPublicAPIMsg + ". Use chisel3.experimental.requireIsChiselType instead", "Chisel 3.6")
-object requireIsChiselType {
-  def apply(node: Data, msg: String = ""): Unit = chisel3.experimental.requireIsChiselType.apply(node, msg)
-}
-
 // Element only direction used for the Binding system only.
 private[chisel3] sealed abstract class BindingDirection
 private[chisel3] object BindingDirection {

core/src/main/scala/chisel3/internal/SourceInfo.scala

@@ -14,17 +14,6 @@ import scala.collection.mutable
 
 package object internal {
 
-  @deprecated("This function has moved to chisel3.experimental", "Chisel 3.6")
-  val prefix = chisel3.experimental.prefix
-  @deprecated("This function has moved to chisel3.experimental", "Chisel 3.6")
-  val noPrefix = chisel3.experimental.noPrefix
-
-  @deprecated("This type has moved to chisel3", "Chisel 3.6")
-  type ChiselException = chisel3.ChiselException
-
-  @deprecated("This type has moved to chisel3", "Chisel 3.6")
-  type InstanceId = chisel3.InstanceId
-
   @implicitNotFound("You are trying to access a macro-only API. Please use the @public annotation instead.")
   trait MacroGenerated
 

core/src/main/scala/chisel3/internal/package.scala

@@ -4,8 +4,8 @@ package chisel3.probe
 
 import chisel3._
 import chisel3.Data.ProbeInfo
-import chisel3.experimental.SourceInfo
-import chisel3.internal.{containsProbe, requireIsChiselType, requireNoProbeTypeModifier, Builder}
+import chisel3.experimental.{requireIsChiselType, SourceInfo}
+import chisel3.internal.{containsProbe, requireNoProbeTypeModifier, Builder}
 
 import scala.language.experimental.macros
 

core/src/main/scala/chisel3/probe/Probe.scala

@@ -7,7 +7,7 @@ import chisel3.internal._
 import chisel3.internal.Builder.pushCommand
 import chisel3.internal.firrtl.ir._
 import chisel3.Data.ProbeInfo
-import chisel3.experimental.SourceInfo
+import chisel3.experimental.{requireIsHardware, SourceInfo}
 import chisel3.reflect.DataMirror.{checkTypeEquivalence, collectAllMembers, hasProbeTypeModifier}
 
 import scala.language.experimental.macros

core/src/main/scala/chisel3/probe/package.scala

@@ -5,7 +5,7 @@ package chisel3.reflect
 import chisel3._
 import chisel3.internal._
 import chisel3.internal.firrtl.ir._
-import chisel3.experimental.{BaseModule, SourceInfo}
+import chisel3.experimental.{requireIsHardware, BaseModule, SourceInfo}
 import scala.reflect.ClassTag
 
 object DataMirror {

core/src/main/scala/chisel3/reflect/DataMirror.scala

@@ -8,8 +8,7 @@ import firrtl.util.{BackendCompilationUtilities => FirrtlBackendCompilationUtili
 import java.io._
 import _root_.logger.LazyLogging
 
-@deprecated("Use object firrtl.util.BackendCompilationUtilities instead", "Chisel 3.5")
-trait BackendCompilationUtilities extends LazyLogging {
+private[chisel3] trait BackendCompilationUtilities extends LazyLogging {
 
   import scala.sys.process.{ProcessBuilder, ProcessLogger, _}
 

src/main/scala/chisel3/Driver.scala

@@ -3,7 +3,7 @@
 package chisel3.util
 
 import chisel3._
-import chisel3.internal.requireIsChiselType
+import chisel3.experimental.requireIsChiselType
 
 import scala.collection.immutable.ListMap
 

src/main/scala/chisel3/util/MixedVec.scala

@@ -61,21 +61,6 @@ object PriorityMux {
   */
 object MuxLookup extends SourceInfoDoc {
 
-  /** Creates a cascade of n Muxs to search for a key value.
-    *
-    * @example {{{
-    * MuxLookup(idx, default, Seq(0.U -> a, 1.U -> b))
-    * }}}
-    *
-    * @param key a key to search for
-    * @param default a default value if nothing is found
-    * @param mapping a sequence to search of keys and values
-    * @return the value found or the default if not
-    */
-  @deprecated("Use MuxLookup(key, default)(mapping) instead", "Chisel 3.6")
-  def apply[S <: UInt, T <: Data](key: S, default: T, mapping: Seq[(S, T)]): T =
-    do_apply(key, default, mapping)
-
   /** @param key a key to search for
     * @param default a default value if nothing is found
     * @param mapping a sequence to search of keys and values