[test] Delete ChiselFreeSpec #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor PortSpec to use FileCheck and flat spec. This was the only remaining test that used `ChiselFreeSpec` which is slated to be deleted. Fix a possible bug in the test where this was trying to check that the automatic clock and reset ports do not have source locators. However, these _do_ get source locators and the original test was not actually checking this. Change the check to lock in the current behavior of these get source locators. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Remove the non-load bearing ChiselFreeSpec. Developers should use Scalatest traits directly for their tests to make them more self-contained. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
added
the
No Release Notes
seldridge
deleted the
dev/seldridge/move-tests-from-ChiselSpec-to-ChiselSim
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete ChiselFreeSpec. Refactor PortsSpec to use AnyFlatSpec and FileCheck. This exposed a problem with what the test was checking, so I am opting to lock in the existing behavior.