[NFC] Format tables for better preview in github and vscode. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stand. Doesn't change generated pdf.
jackkoenig
approved these changes
Jan 23, 2024
darthscsi
changed the title
mmaloney-sf
reviewed
Jan 23, 2024
seldridge
reviewed
Jan 23, 2024
darthscsi
changed the title
|
Format actually appears to be unstable and not just converging to a fixed point. 🧐 I'm confirming this on my end. |
seldridge
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
This is a nice improvement!
I'm not seeing any instability in the formatting on 3.11.1.1. I thought I saw some on 3.1.8. However, I now upgraded and can't easily downgrade.
What version of pandoc are you using? (pandoc --version) If you are on 3.11.1.1, can you add a commit that bumps the version here:
firrtl-spec/.github/workflows/pandoc.yml
Lines 27 to 28 in 547b010
If you are on 3.1.8, then no need to change anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to a table implementation which github and vscode understand.
Doesn't change generated pdf.