[minor] Add inline layer convention #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the inline layer convention to the FIRRTL spec and FIRRTL ABI. Clarify some language in the spec around layers. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
added a commit
to llvm/circt
that referenced
this pull request
Dec 6, 2024
Partially implement the inline layer convention ABI as described in the FIRRTL Spec/ABI PR for this feature [[1]]. This changes the name of the macro to be something that is more descriptive and cannot collide with FIRRTL identifiers (which are supposed to not include `$`). This does not implement the full ABI. Namely, it does not correctly handle circuits with multiple public modules. (Notably, this isn't implemented for the bind layer convention either.) This will be fixed in a follow-on. [1]: chipsalliance/firrtl-spec#262 Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the inline layer convention to the FIRRTL spec and FIRRTL ABI. Clarify some language in the spec around layers.