Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Replace "mod" with "rem" in primop_2expr_keyword rule #277

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

nathsou
Copy link
Contributor

@nathsou nathsou commented Feb 1, 2025

Fixes #276

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Would you be able to add a line in the revision-history.yaml? E.g.:

diff --git a/revision-history.yaml b/revision-history.yaml
index a5d2a69..52fb682 100644
--- a/revision-history.yaml
+++ b/revision-history.yaml
@@ -5,6 +5,7 @@ revisionHistory:
   # additions to the specification should append entries here.
   thisVersion:
     spec:
+      - Correct grammar for modulus primitive operator.
     abi:
   # Information about the old versions.  This should be static.
   oldVersions:

@nathsou
Copy link
Contributor Author

nathsou commented Feb 2, 2025

Nice catch!

Would you be able to add a line in the revision-history.yaml? E.g.:

diff --git a/revision-history.yaml b/revision-history.yaml
index a5d2a69..52fb682 100644
--- a/revision-history.yaml
+++ b/revision-history.yaml
@@ -5,6 +5,7 @@ revisionHistory:
   # additions to the specification should append entries here.
   thisVersion:
     spec:
+      - Correct grammar for modulus primitive operator.
     abi:
   # Information about the old versions.  This should be static.
   oldVersions:

Done!

@nathsou nathsou requested a review from seldridge February 2, 2025 10:09
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seldridge seldridge merged commit 9205506 into chipsalliance:main Feb 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammar mentions "mod" instead of "rem" in primop_2expr_keyword rule
2 participants