Skip to content

Update to Chisel 6.7, use new annotation API #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Update to Chisel 6.7, use new annotation API #3724

merged 2 commits into from
Mar 10, 2025

Conversation

tymcauley
Copy link
Contributor

@tymcauley tymcauley commented Mar 9, 2025 •
edited
Loading

Resolves #3722.

Related issue: #3722

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

Update to Chisel 6.7.0

tymcauley added a commit to tymcauley/chipyard that referenced this pull request Mar 9, 2025
@tymcauley
Bump submodules for new Chisel annotation API
3043ad4 
Submodule PRs:

- chipsalliance/rocket-chip#3724
- chipsalliance/diplomacy#19
- ucb-bar/constellation#82
@tymcauley tymcauley mentioned this pull request Mar 9, 2025
Merged
16 tasks
tymcauley added 2 commits March 9, 2025 16:55
@tymcauley
Bump Chisel to 6.7.0
d56099d 
This is required for the new Chisel annotations API:
chipsalliance/chisel#4643
@tymcauley
Use new Chisel annotations API
5d76b41 
The `ChiselAnnotation` API is going away in Chisel 7. Also in Chisel 7,
this trait can be replaced by
`chisel3.util.experimental.InlineInstanceAllowDedup`:
chipsalliance/chisel#4508
@tymcauley tymcauley force-pushed the new-chisel-anno-api branch from d80ff7d to 5d76b41 Compare March 9, 2025 23:56
@tymcauley
Copy link
Contributor Author

Looks like because the mill files in this repo are a bit old, and the chisel submodule is pretty out-of-date, updating to a newer version of the Scala compiler breaks CI. I don't know how the nix flow works too well, so seems like someone who can work with that should do a bump of the Chisel source dependency at some point, but it's not blocking for this PR.

@jerryz123 jerryz123 merged commit a54937e into chipsalliance:dev Mar 10, 2025
28 checks passed
@tymcauley tymcauley deleted the new-chisel-anno-api branch March 10, 2025 22:39
@tymcauley tymcauley mentioned this pull request Mar 10, 2025
Closed
tymcauley added a commit to tymcauley/chipyard that referenced this pull request Mar 10, 2025
@tymcauley
Bump submodules for new Chisel annotation API
45969e0 
Submodule PRs:

- chipsalliance/rocket-chip#3724
- chipsalliance/diplomacy#19
- ucb-bar/constellation#82
tymcauley added a commit to tymcauley/chipyard that referenced this pull request Mar 10, 2025
@tymcauley
Bump submodules for new Chisel annotation API
4020e82 
Submodule PRs:

- chipsalliance/rocket-chip#3724
- chipsalliance/diplomacy#19
- ucb-bar/constellation#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymcauley @jerryz123