refactor: extract yt-dlp

Author: christian-fei

lib/youtube.js

@@ -1,36 +1,22 @@
 import spawn from 'nano-spawn'
 import fs from 'fs'
+import { video, subtitles } from './yt-dlp.js'
 
 export const ytUrlRegExp = /^(https?:\/\/)?(www\.)?(youtube\.com|youtu\.be)\/watch\?v=([^&]+).*/
 
 const fetchYoutubeHeaders = {
   'Accept-Language': 'en',
   'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36'
 }
-const subtitlesYTDLPArgs = `--write-subs --write-auto-subs --sub-format vtt --convert-subs srt -k`
-const videoYTDLPArgs = quality => `--concurrent-fragments 5 --newline --progress --progress-delta 1 --merge-output-format webm/mp4 -f bestvideo[height<=${quality}]+bestaudio/best[height<=${quality}] --sponsorblock-remove sponsor`
-
-
-function getOptionalCookiesPath() {
-  if (fs.existsSync('/app/cookies.txt')) return '/app/cookies.txt'
-  if (fs.existsSync('./cookies.txt')) return './cookies.txt'
-  console.log('cookies not set')
-  return
-}
 
 export async function downloadVideo(id, repo, callback = () => {}) {
   return new Promise(async (resolve, reject) => {
     if (isUnsupportedUrl(id)) return reject(new Error('unsupported url'))
-    
     if (isYouTubeUrl(id)) id = extractIdFromUrl(id)
     try {
-      const cookiesPath = getOptionalCookiesPath()
-      let cookiesOption = cookiesPath ? `--cookies ${cookiesPath}` : ''
       const quality = repo.getVideoQuality()
-      const commandArgs = `-o ./data/videos/${id}.%(ext)s ${cookiesOption} ${videoYTDLPArgs(quality)} ${subtitlesYTDLPArgs} -- ${id}`.split(/ +/)
-      console.log('running yt-dlp', commandArgs.join(' '))
       let location, format
-      for await (const line of spawn('yt-dlp', commandArgs)) {
+      for await (const line of video(id, quality)) {
         console.log(line)
         callback(line)
         if (line.startsWith('[Merger] Merging formats into')) {
@@ -66,13 +52,8 @@ export async function getVideoSubtitles (id, callback = () => {}) {
   return new Promise(async (resolve, reject) => {
     try {
       const transcriptPath = `./data/videos/${id}.en.srt`
-      const cookies = getOptionalCookiesPath()
-      let cookiesOption = ''
-      if (cookies) cookiesOption = `--cookies ./cookies.txt`
       if (!fs.existsSync(transcriptPath)) {
-        const commandArgs = `-o ./data/videos/${id} --skip-download ${cookiesOption} ${subtitlesYTDLPArgs} -- ${id}`.split(/ +/)
-        console.log('running yt-dlp', commandArgs.join(' '))
-        for await (const line of spawn('yt-dlp', commandArgs)) {
+        for await (const line of subtitles(id)) {
           console.log(line)
           callback(line)
         }

lib/yt-dlp.js

@@ -0,0 +1,27 @@
+import fs from 'fs'
+import spawn from 'nano-spawn'
+
+const subtitlesYTDLPArgs = `--write-subs --write-auto-subs --sub-format vtt --convert-subs srt -k`
+const videoYTDLPArgs = quality => `--concurrent-fragments 5 --newline --progress --progress-delta 1 --merge-output-format webm/mp4 -f bestvideo[height<=${quality}]+bestaudio/best[height<=${quality}] --sponsorblock-remove sponsor`
+
+export function video(id, quality) {
+  const cookiesPath = getOptionalCookiesPath()
+  let cookiesOption = cookiesPath ? `--cookies ${cookiesPath}` : ''
+  const commandArgs = `-o ./data/videos/${id}.%(ext)s ${cookiesOption} ${videoYTDLPArgs(quality)} ${subtitlesYTDLPArgs} -- ${id}`.split(/ +/)
+  console.log('running yt-dlp', commandArgs.join(' '))
+  return spawn('yt-dlp', commandArgs)
+}
+export function subtitles(id) {
+  const cookiesPath = getOptionalCookiesPath()
+  let cookiesOption = cookiesPath ? `--cookies ${cookiesPath}` : ''
+  const commandArgs = `-o ./data/videos/${id} --skip-download ${cookiesOption} ${subtitlesYTDLPArgs} -- ${id}`.split(/ +/)
+  console.log('running yt-dlp', commandArgs.join(' '))
+  return spawn('yt-dlp', commandArgs)
+}
+
+function getOptionalCookiesPath() {
+  if (fs.existsSync('/app/cookies.txt')) return '/app/cookies.txt'
+  if (fs.existsSync('./cookies.txt')) return './cookies.txt'
+  console.log('cookies not set')
+  return
+}