Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the error related to empty lists passed to reads arrays in bacpaq #66

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

anwarMZ
Copy link
Member

@anwarMZ anwarMZ commented Oct 9, 2024

This updated code fixes the issue by converting the empty string in the sample sheet to a null value. This makes it easier to check for null values and filter them out for nanopore and Illumina samples

@anwarMZ anwarMZ requested a review from jimmyliu1326 October 9, 2024 04:58
@anwarMZ anwarMZ changed the base branch from master to dev October 9, 2024 04:59
@anwarMZ anwarMZ linked an issue Oct 9, 2024 that may be closed by this pull request
@anwarMZ anwarMZ added the bug Something isn't working label Oct 9, 2024
Copy link
Collaborator

@jimmyliu1326 jimmyliu1326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anwarMZ anwarMZ merged commit cc8b486 into dev Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAT_NANOPORE_FASTQ
2 participants