Skip to content

Add label attribute to names schema #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.1
Choose a base branch
from
Open

Add label attribute to names schema #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions schemas/input/csl-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@
"description": "E.g. rendered as 'Smith, J. [@JSmith]'",
"type": "string"
},
"label": {
"title": "Non-default label to use when rendering name",
"description": "Overrides the default label for the role. e.g. to indicate a subtype of a role or specific MARC or CRediT roles."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't we need a "type": "string" here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not sure how this happened (seemed to happen with the last merge I did), but there are multiples places where the $ref syntax got screwed up. We need to add to the python test code to catch these problems in the future.

You can fix by find-replace #definition -> #/definition.

Copy link
Member

@bdarcus bdarcus Aug 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this being locale-specific may be an issue. But I assume @bwiernik has already an idea how this could play nicely with #240

He mentions this in this comment, which I missed earlier.

How does this PR relate to the idea in that comment @bwiernik?

Is this really an uncontrolled term name?

Notwithstanding the question of whether to add an enum of controlled values, should probably have a regex pattern to constrain it to a token?

Edit - here's the full MARC list as linked RDF data.

http://id.loc.gov/vocabulary/relators.html

Example:

http://id.loc.gov/vocabulary/relators/abr.html

SKOS RDF:

<rdf:RDF xmlns:skos="http://www.w3.org/2004/02/skos/core#" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:rdfs="http://www.w3.org/1999/02/22-rdf-schema#" xmlns:cs="http://purl.org/vocab/changeset/schema#" xmlns:skosxl="http://www.w3.org/2008/05/skos-xl#">
  <rdf:Description rdf:about="http://id.loc.gov/vocabulary/relators/abr">
    <rdf:type rdf:resource="http://www.w3.org/2004/02/skos/core#Concept"/>
    <skos:prefLabel>Abridger</skos:prefLabel>
    <skos:definition xml:lang="en">A person, family, or organization contributing to a resource by shortening or condensing the original work but leaving the nature and content of the original work substantially unchanged. For substantial modifications that result in the creation of a new work, see author</skos:definition>
    <skos:notation>abr</skos:notation>
    <skos:inScheme rdf:resource="http://id.loc.gov/vocabulary/relators"/>
  </rdf:Description>
</rdf:RDF>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think you should add "examples" here, as you see elsewhere in the schema.

},
"parse-names": {
"type": "boolean"
},
Expand Down