Fixes current branch check problem when tag is pushed to push docker tags

[gurkanindibay]

After building main docker images, we need to create tagged docker images such as 10.0-alpine by creating new tag on master branch
While tagging, Github Actions clones the code in detached state and when in this state we can not get current branch . Since we are using current branch to decide whether images weill published or not, and we can not use it in tag push case , we need to put tag existence case on master branch to be able to handle tag push case
Som improvements are suggested. These are in the issue below
#192

[gurkanindibay]

This is the new method to check whether branch contains tag

[gurkanindibay]

In case of tag push, tag contains check is used instead of branch name

[gurkanindibay]

Centralized the image publish status to manage the publish status in one place

[hanefi]

I do not really understand the purpose of the new publish parameter in many of your functions. Can you please choose a better name?

[hanefi]

Why do we need this? Do you really need all the git history?

[gurkanindibay]

https://github.com/citusdata/tools/runs/3653741920?check_suite_focus=true
I can not test the is_tag_on_branch since devevlop is not fetched

[hanefi]

Please organize your imports.

Here is my suggestion:

import base64
import os
import re
import shlex
import subprocess
from datetime import datetime
from enum import Enum
from typing import Dict, List, Tuple

import git
import gnupg
import pathlib2
import requests
from git import GitCommandError, Repo
from github import Commit, Github, PullRequest, Repository
from jinja2 import Environment, FileSystemLoader
from parameters_validation import validate_parameters

from .common_validations import is_tag, is_version
from .dbconfig import RequestLog, RequestType

Imports should be divided according to what is being imported. There are generally three groups:

1. standard library imports (Python’s built-in modules)
2. related third party imports (modules that are installed and do not belong to the current application)
3. local application imports (modules that belong to the current application)

Each group of imports should be separated by a blank space.

See https://realpython.com/absolute-vs-relative-python-imports/#styling-of-import-statements for more on this

[hanefi]

Please consider updating your IDE to organize your imports on save, so it always keeps them in the correct format.

[gurkanindibay]

Configured my IDE and fixed as you wish

[hanefi]

@gurkanindibay I do not really get why we need to have a really convoluted solution to this problem.

I think we have 2 scenarios where we push images to DockerHub.

on:
  push:
    branches:
      - master

on:
  push:
    tags:
      - "**"

In either case, we should be able to get the ref properly by using ${GITHUB_REF#refs/*/} that will resolve to the branch name in case 1, and tag name in case 2.

Note that you may need separate workflow definitions to allow this.

Let's have a chat offline and create a better design for solving this problem.