Some random citus_dev improvements #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JelteF
commented
Feb 23, 2024
•
JelteF
commented
- citus_dev: pass arguments directly to createNodeCommands
- Don't fsync by default
- Remove trailing whitespace
- Add editorconfig
- Add some basic gitignore stuff for citus_dev
- Add --no-lib flag to not load citus shared library
- Configure port in the config file instead of pg_ctl
- Configure logging the config file instead of pg_ctl
- remove nightlies for EOL distros
JelteF
force-pushed
the
random-improvements
branch
3 times, most recently
from
ef6e74d to
5e01b32
Compare
thanodnl
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
looking good, lets make sure before merging @gurkanindibay is ok with us removing old distributions. I don't know in what manner the tools repo is used for packaging/building/testing anymore.
Comment on lines
26
to
35
| - el/7 | ||
| - el/8 | ||
| - ol/7 | ||
| - debian/buster | ||
| - debian/bullseye | ||
| - debian/bookworm | ||
| - ubuntu/bionic | ||
| - ubuntu/focal | ||
| - ubuntu/jammy | ||
| - ubuntu/kinetic |
There was a problem hiding this comment.
@gurkanindibay could you double check these changes?
There was a problem hiding this comment.
We can remove ubuntu/kinetic however, we can not remove other ones. We still support el/7 and ol/7
citus_dev/citus_dev
Outdated
Comment on lines
59
to
62
| if arguments['--no-lib']: | ||
| shared_preload_libraries = ['pg_stat_statements'] | ||
| else: | ||
| shared_preload_libraries = ['citus', 'pg_stat_statements'] |
There was a problem hiding this comment.
This works for now, but it becomes more cumbersome if we need more preload libraries in the future.
Suggested change
| if arguments['--no-lib']: | |
| shared_preload_libraries = ['pg_stat_statements'] | |
| else: | |
| shared_preload_libraries = ['citus', 'pg_stat_statements'] | |
| shared_preload_libraries = ['pg_stat_statements'] | |
| # double negation, what does it mean? | |
| # we do add citus if we do _not_ provide the `--no-lib` flag | |
| # because citus needs to be at the beginning of the list we perform this check last, and insert `citus` at index 0, which is the beginning of the list | |
| if not arguments['--no-lib']: | |
| shared_preload_libraries.insert(0, 'citus') |
citus_dev/citus_dev
Outdated
| @@ -188,7 +201,7 @@ def main(arguments): | |||
| clustername = arguments["<name>"] | |||
| port = int(arguments["--port"]) | |||
| for role in getRoles(clustername): | |||
| run(f'pg_ctl {pgctl_flags} start -D {clustername}/{role} -o "-p {port}" -l {role}_logfile') | |||
| run(f'pg_ctl {pgctl_flags} start -D {clustername}/{role} -o "-p {port}"') | |||
There was a problem hiding this comment.
can the port be removed if we have it in the config now?
possibly we would also need to remove the flag from start/restart, given it's a property of the cluster now, not a runtime argument.
citus_dev/citus_dev
Outdated
| @@ -2,7 +2,7 @@ | |||
| """citus_dev | |||
|
|
|||
| Usage: | |||
| citus_dev make <name> [--size=<count>] [--port=<port>] [--use-ssl] [--no-extension] [--destroy] [--init-with=<sql_file>] [--init-worker-with=<sql_file>] [--with-pgbouncer] | |||
| citus_dev make <name> [--size=<count>] [--port=<port>] [--use-ssl] [--no-extension] [--no-lib] [--destroy] [--init-with=<sql_file>] [--init-worker-with=<sql_file>] [--with-pgbouncer] [--fsync] | |||
| citus_dev restart <name> [--watch] [--port=<port>] | |||
| citus_dev (start|stop) <name> [--port=<port>] [--force] | |||
There was a problem hiding this comment.
Guess --port can be removed here
JelteF
force-pushed
the
random-improvements
branch
from
5e01b32 to
55e7f3a
Compare
JelteF
force-pushed
the
random-improvements
branch
from
55e7f3a to
9e927cf
Compare
JelteF
force-pushed
the
random-improvements
branch
from
9e927cf to
e91bcb9
Compare
They were failing
JelteF
force-pushed
the
random-improvements
branch
from
e91bcb9 to
6919d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.