Merge pull request #95 from nymag/fix-db-list

fix db failure when list is requested multiple times

lib/responses.js

@@ -306,14 +306,14 @@ function expectHTML(fn, res) {
  *   options.filters: array
  */
 function list(options) {
-  options = options || {};
-
   return function (req, res) {
-    var listOptions = _.defaults(options || {}, {
+    var list,
+      listOptions = _.assign({
         prefix: normalizePath(req.baseUrl + req.url),
         values: false
-      }),
-      list = db.list(listOptions);
+      }, options);
+
+    list = db.list(listOptions);
 
     res.set('Content-Type', 'application/json');
     list.pipe(res);
@@ -325,9 +325,9 @@ function list(options) {
  */
 function listWithoutVersions() {
   var options = {
-    transforms: [filter({wantStrings: true}, function (str) {
-      return str.indexOf('@') === -1;
-    })]
+    transforms: function () {
+      return [filter({wantStrings: true}, function (str) { return str.indexOf('@') === -1; })];
+    }
   };
   return list(options);
 }

lib/services/db.js

@@ -106,11 +106,18 @@ module.exports.list = function (options) {
     transformOptions.isArray = true;
   }
 
-  // apply all transforms
   readStream = db.createReadStream(options);
-  readStream = _.reduce(options.transforms, function (readStream, transform) {
-    return readStream.pipe(transform);
-  }, readStream);
+
+  if (_.isFunction(options.transforms)) {
+    options.transforms = options.transforms();
+  }
+
+  // apply all transforms
+  if (options.transforms) {
+    readStream = _.reduce(options.transforms, function (readStream, transform) {
+      return readStream.pipe(transform);
+    }, readStream);
+  }
 
   return readStream.pipe(jsonTransform(transformOptions));
 };