Skip to content

Run lint for PRs. #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2025
Merged

Run lint for PRs. #184

merged 4 commits into from
May 6, 2025

Conversation

jsdt
Copy link
Contributor

@jsdt jsdt commented May 2, 2025

Description of Changes

Fixes a file that wasn't formatted, and adds the lint check to PRs.

This also includes from .gitattributes changes to hide generated files from diffs.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ffe944c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 2, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@184

commit: ffe944c

@jsdt jsdt marked this pull request as ready for review May 2, 2025 16:49
@jsdt jsdt requested a review from bfops May 2, 2025 16:49
bfops
bfops reviewed May 2, 2025
View reviewed changes
bfops
bfops approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsdt jsdt merged commit 3e89c7d into main May 6, 2025
8 checks passed
@jsdt jsdt deleted the jsdt/lint-check branch May 6, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfops bfops bfops approved these changes

Assignees

@bfops bfops

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsdt @bfops