Merge pull request #24 from ingrammicro/fix-small-code-style-improvem…

…ents

Fix small code style improvements

examples/example.php

@@ -5,7 +5,6 @@
 
 class MyAppRequests extends \Connect\RequestsProcessor
 {
-
     public function processRequest($req)
     {
         $req->asset->tiers['customer']->name;
@@ -52,12 +51,9 @@ public function processRequest($req)
 
 
 try {
-
     $rp = new MyAppRequests();
     $rp->process();
-
 } catch (Exception $e) {
     \Connect\Logger::get()->error($e->getMessage());
     \Connect\Logger::get()->dump();
 }
-

src/Account.php

@@ -39,5 +39,4 @@ class Account extends Model
      */
 
     public $contact_info;
-
-}
+}

src/Activation.php

@@ -18,4 +18,4 @@ class Activation extends Model
      * @var
      */
     public $link;
-}
+}

src/ActivationTemplateResponse.php

@@ -27,4 +27,4 @@ public function __construct($templateid)
     {
         $this->templateid = $templateid;
     }
-}
+}

src/ActivationTileResponse.php

@@ -30,5 +30,4 @@ public function __construct($msg = null)
             $this->activationTile = $msg;
         }
     }
-
-}
+}

src/Agreement.php

@@ -22,5 +22,4 @@ class Agreement extends Model
      * @var
      */
     public $name;
-
-}
+}

src/Asset.php

@@ -86,4 +86,4 @@ public function getItemByMPN($mpn)
 
         return ($item) ? $item : null;
     }
-}
+}

src/Assignee.php

@@ -22,4 +22,4 @@ class Assignee extends Model
      * @var
      */
     public $name;
-}
+}

src/Choice.php

@@ -22,5 +22,4 @@ class Choice extends Model
      * @var
      */
     public $label;
-
-}
+}

src/Config.php

@@ -98,7 +98,7 @@ public function __construct($source)
             case 'object':
             case 'array':
                 break;
-            default :
+            default:
                 throw new ConfigException("Invalid argument for \\Connect\\Config class constructor: " . gettype($source));
         }
 
@@ -152,7 +152,7 @@ public function setRuntimeServices($runtimeServices)
 
     public function setProducts($product)
     {
-        if(is_string($product)) {
+        if (is_string($product)) {
             $product = [$product];
         }
 

src/ConfigException.php

@@ -27,4 +27,4 @@ public function __construct($message, $prop = null)
             $this->message = $message . " for property " . $prop;
         }
     }
-}
+}

src/ConfigPropertyMissed.php

@@ -20,4 +20,4 @@ public function __construct($prop)
     {
         parent::__construct('Value is not set ', $prop);
     }
-}
+}

src/Configuration.php

@@ -79,4 +79,4 @@ public function getParameterByID($id)
 
         return ($param) ? $param : null;
     }
-}
+}

src/Connection.php

@@ -31,4 +31,4 @@ class Connection extends Model
      * @var Vendor
      */
     public $vendor;
-}
+}

src/Constraints.php

@@ -27,5 +27,4 @@ class Constraints extends Model
      * @var Choice[]
      */
     public $choices;
-
-}
+}

src/Contact.php

@@ -22,4 +22,4 @@ class Contact extends Model
      * @var PhoneNumber
      */
     public $phone_number;
-}
+}

src/ContactInfo.php

@@ -26,4 +26,3 @@ class ContactInfo extends Model
     public $postal_code;
     public $state;
 }
-

src/Contract.php

@@ -46,5 +46,4 @@ class Contract extends Model
      * @var Marketplace
      */
     public $marketplace;
-
-}
+}

src/Creator.php

@@ -22,5 +22,4 @@ class Creator extends Model
      * @var
      */
     public $name;
-
-}
+}

src/Customer.php

@@ -22,4 +22,4 @@ class Customer extends Model
      * @var ContactInfo
      */
     public $contact_info;
-}
+}

src/Events.php

@@ -17,4 +17,4 @@ class Events extends Model
     public $inquired;
     public $updated;
     public $created;
-}
+}

src/Exception.php

@@ -25,6 +25,7 @@ class Exception extends \Exception
      */
     public function __construct($message, $code = 'unknown', $object = null)
     {
+        parent::__construct();
         $this->code = $code;
         $this->message = $message;
         $this->object = $object;

src/Fail.php

@@ -24,4 +24,4 @@ public function __construct($message = null)
     {
         parent::__construct($message ? $message : 'Request processing failed', 'fail');
     }
-}
+}

src/FulfillmentAutomation.php

@@ -128,8 +128,10 @@ public function process()
     protected function dispatchTierConfig($tierConfigRequest)
     {
         try {
-            if ($this->config->products && !in_array($tierConfigRequest->configuration->product->id,
-                    $this->config->products)) {
+            if ($this->config->products && !in_array(
+                $tierConfigRequest->configuration->product->id,
+                $this->config->products
+            )) {
                 return 'Invalid product';
             }
 
@@ -144,30 +146,35 @@ protected function dispatchTierConfig($tierConfigRequest)
             }
 
             if ($msg instanceof ActivationTemplateResponse) {
-                $this->sendRequest('POST', '/tier/config-requests/' . $tierConfigRequest->id . '/approve',
-                    '{"template": {"id": "' . $msg->templateid . '"}}');
+                $this->sendRequest(
+                    'POST',
+                    '/tier/config-requests/' . $tierConfigRequest->id . '/approve',
+                    '{"template": {"id": "' . $msg->templateid . '"}}'
+                );
                 $processingResult = 'succeed (Activated using template ' . $msg->templateid . ')';
             } else {
-                $this->sendRequest('POST', '/tier/config-requests/' . $tierConfigRequest->id . '/approve',
-                    '{"template": {"representation": "' . $msg->activationTile . '"}}');
+                $this->sendRequest(
+                    'POST',
+                    '/tier/config-requests/' . $tierConfigRequest->id . '/approve',
+                    '{"template": {"representation": "' . $msg->activationTile . '"}}'
+                );
                 $processingResult = 'succeed (' . $msg->activationTile . ')';
             }
-
         } catch (Inquire $e) {
             // update parameters and move to inquire
             $this->updateTierConfigRequestParameters($tierConfigRequest, $e->params);//WORKING HERE!
             $this->sendRequest('POST', '/tier/config-requests/' . $tierConfigRequest->id . '/inquire', '{}');
             $processingResult = 'inquire';
-
         } catch (Fail $e) {
             // fail request
-            $this->sendRequest('POST', '/tier/config-requests/' . $tierConfigRequest->id . '/fail',
-                '{"reason": "' . $e->getMessage() . '"}');
+            $this->sendRequest(
+                'POST',
+                '/tier/config-requests/' . $tierConfigRequest->id . '/fail',
+                '{"reason": "' . $e->getMessage() . '"}'
+            );
             $processingResult = 'fail';
-
         } catch (Skip $e) {
             $processingResult = 'skip';
-
         }
 
         $this->logger->info("Finished processing of Tier Config Request with ID=" . $tierConfigRequest->id . " result=" . $processingResult);
@@ -198,30 +205,35 @@ protected function dispatch($request)
             }
 
             if ($msg instanceof ActivationTemplateResponse) {
-                $this->sendRequest('POST', '/requests/' . $request->id . '/approve',
-                    '{"template_id": "' . $msg->templateid . '"}');
+                $this->sendRequest(
+                    'POST',
+                    '/requests/' . $request->id . '/approve',
+                    '{"template_id": "' . $msg->templateid . '"}'
+                );
                 $processingResult = 'succeed (Activated using template ' . $msg->templateid . ')';
             } else {
-                $this->sendRequest('POST', '/requests/' . $request->id . '/approve',
-                    '{"activation_tile": "' . $msg->activationTile . '"}');
+                $this->sendRequest(
+                    'POST',
+                    '/requests/' . $request->id . '/approve',
+                    '{"activation_tile": "' . $msg->activationTile . '"}'
+                );
                 $processingResult = 'succeed (' . $msg->activationTile . ')';
             }
-
         } catch (Inquire $e) {
             // update parameters and move to inquire
             $this->updateParameters($request, $e->params);
             $this->sendRequest('POST', '/requests/' . $request->id . '/inquire', '{}');
             $processingResult = 'inquire';
-
         } catch (Fail $e) {
             // fail request
-            $this->sendRequest('POST', '/requests/' . $request->id . '/fail',
-                '{"reason": "' . $e->getMessage() . '"}');
+            $this->sendRequest(
+                'POST',
+                '/requests/' . $request->id . '/fail',
+                '{"reason": "' . $e->getMessage() . '"}'
+            );
             $processingResult = 'fail';
-
         } catch (Skip $e) {
             $processingResult = 'skip';
-
         }
 
         $this->logger->info("Finished processing of request ID=" . $request->id . " result=" . $processingResult);
@@ -341,8 +353,10 @@ public function renderTemplate($templateId, $request)
      */
     public function getTierConfigByProduct($tierId, $productId)
     {
-        $body = $this->sendRequest('GET',
-            '/tier/config-requests?status=approved&configuration__product__id=' . $productId . '&configuration__account__id=' . $tierId);
+        $body = $this->sendRequest(
+            'GET',
+            '/tier/config-requests?status=approved&configuration__product__id=' . $productId . '&configuration__account__id=' . $tierId
+        );
         $model = Model::modelize('tierconfigrequests', json_decode($body));
         if (count($model) > 0) {
             return $model[0]->configuration;
@@ -360,14 +374,13 @@ public function getTierConfigByProduct($tierId, $productId)
     public function getTierParameterByProductAndTierId($parameterId, $tierId, $productId)
     {
         $tierConfig = $this->getTierConfigByProduct($tierId, $productId);
-        if(!$tierConfig){
+        if (!$tierConfig) {
             return null;
         }
         $param = current(array_filter($tierConfig->params, function (Param $param) use ($parameterId) {
             return ($param->id === $parameterId);
         }));
 
         return ($param) ? $param : null;
-
     }
-}
+}

src/FulfillmentAutomationInterface.php

@@ -17,4 +17,4 @@ interface FulfillmentAutomationInterface
     public function processRequest($request);
 
     public function processTierConfigRequest($tierConfigRequest);
-}
+}

src/Hub.php

@@ -33,4 +33,4 @@ class Hub extends Model
      * @var
      */
     public $uuid;
-}
+}

src/Inquire.php

@@ -27,4 +27,4 @@ public function __construct($params)
         $this->params = $params;
         parent::__construct('Activation parameters are required', 'inquiry');
     }
-}
+}

src/Item.php

@@ -31,4 +31,4 @@ class Item extends Model
      * @var Renewal
      */
     public $renewal;
-}
+}

src/Listing.php

@@ -38,5 +38,4 @@ class Listing extends Model
      * @var Provider;
      */
     public $provider;
-
-}
+}

src/Logger/LogRecord.php

@@ -25,4 +25,4 @@ public function __construct($level, $message, $time = 0)
         $this->message = $message;
         $this->time = ($time === 0) ? time() : $time;
     }
-}
+}

src/Logger/LogSession.php

@@ -70,4 +70,4 @@ public function count()
     {
         return count($this->sessionLog);
     }
-}
+}

src/Logger/LoggerInterface.php

@@ -93,4 +93,4 @@ public function setLogLevel($level);
      * Dump session log to current log, and reset session
      */
     public function dump();
-}
+}

src/Marketplace.php

@@ -17,4 +17,4 @@ class Marketplace extends Model
     public $id;
     public $name;
     public $icon;
-}
+}

src/Message.php

@@ -26,4 +26,4 @@ public function __construct($message, $code, $object = null)
     {
         parent::__construct($message, $code, $object);
     }
-}
+}