Skip to content

Commit d5f0e33

Browse files
authored
Merge pull request #30 from cloudblue/LITE-25724-issue-status-fulfillment_requests_line_item
LITE-25724: Fix line item report for fulfillment
2 parents 24eec99 + c93a5c2 commit d5f0e33

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

reports/fulfillment_requests_line_item/entrypoint.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@
99
from ..utils import convert_to_datetime, get_basic_value, get_value, today_str
1010

1111
HEADERS = (
12-
'Request ID', 'Request Type',
12+
'Request ID', 'Request Type', 'Request Status',
1313
'Created At', 'Updated At', 'Exported At',
1414
'Item ID', 'Item Name', 'Item Type', 'Item Unit Of measure', 'Item MPN', 'Item Period',
1515
'Quantity', 'Customer ID', 'Customer Name', 'Customer External ID',
1616
'Tier 1 ID', 'Tier 1 Name', 'Tier 1 External ID',
1717
'Tier 2 ID', 'Tier 2 Name', 'Tier 2 External ID',
1818
'Provider ID', 'Provider Name', 'Vendor ID', 'Vendor Name',
1919
'Product ID', 'Product Name', 'Asset ID', 'Asset External ID',
20-
'Transaction Type', 'Hub ID', 'Hub Name', 'Request Status',
20+
'Transaction Type', 'Hub ID', 'Hub Name', 'Asset Status',
2121
)
2222

2323

@@ -84,6 +84,7 @@ def _process_line(item, request, connection):
8484
return (
8585
get_basic_value(request, 'id'),
8686
get_basic_value(request, 'type'),
87+
get_basic_value(request, 'status'),
8788
convert_to_datetime(
8889
get_basic_value(request, 'created'),
8990
),
Binary file not shown.

tests/test_fulfillment_requests_line_item.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def test_generate_csv_renderer(progress, client_factory, response_factory, ff_re
130130

131131
assert len(result) == 19
132132
assert result[0] == HEADERS
133-
assert len(result[0]) == 33
133+
assert len(result[0]) == 34
134134
assert result[0][0] == 'Request ID'
135135
assert progress.call_count == 2
136136
assert progress.call_args == ((2, 2),)
@@ -154,7 +154,7 @@ def test_generate_json_renderer(progress, client_factory, response_factory, ff_r
154154
result = list(generate(client, PARAMETERS, progress, renderer_type='json'))
155155

156156
assert len(result) == 18
157-
assert len(result[0]) == 33
157+
assert len(result[0]) == 34
158158
assert result[0]['request_id'] == 'PR-1895-0864-1238-001'
159159
assert progress.call_count == 1
160160
assert progress.call_args == ((1, 1),)

0 commit comments

Comments
 (0)