Skip to content

Updated cert-manager to automatically create a ServiceAccount #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

Updated cert-manager to automatically create a ServiceAccount #136

merged 3 commits into from
Apr 4, 2025

Conversation

Arzianghanchi
Copy link
Contributor

What

  • Automatically create a ServiceAccount with necessary permissions for the provided HostedZone in cert-manager.
  • Configured IRSA (Identity Role Switching) to grant required permissions to the ServiceAccount.

Why

  • Add Feature: Previously, the service account was not being created automatically.
  • Improve security: By granting the correct permissions to the ServiceAccount, we ensure that cert-manager can access Route53 resources without excessive privileges.

@Arzianghanchi
Updated cert-manager to automatically create a ServiceAccount with th…
086db0b 
…e necessary permissions for the provided HostedZone.
h1manshu98
h1manshu98 previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci enabled auto-merge (squash) April 2, 2025 14:21
auto-merge was automatically disabled April 4, 2025 15:31

Head branch was pushed to by a user without write access

@Arzianghanchi Arzianghanchi requested a review from a team as a code owner April 4, 2025 15:31
@anmolnagpal anmolnagpal enabled auto-merge (squash) April 4, 2025 22:43
@anmolnagpal anmolnagpal merged commit c30d4fc into clouddrove:master Apr 4, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arzianghanchi @anmolnagpal @h1manshu98