[api] Improve filename handling in Content-Disposition header for /download API

Author: Harshg999

apps/filebrowser/src/filebrowser/api.py

@@ -22,6 +22,7 @@
 import mimetypes
 import posixpath
 from io import BytesIO as string_io
+from urllib.parse import quote
 
 from django.core.files.uploadhandler import StopUpload
 from django.core.paginator import EmptyPage, Paginator
@@ -224,7 +225,14 @@ def download(request):
       request.GET.get('disposition') if request.GET.get('disposition') == 'inline' and _can_inline_display(path) else 'attachment'
     )
 
-    response['Content-Disposition'] = f'{content_disposition}; filename="{stats["name"]}"'
+    # Extract filename for HDFS and OFS for now because the path stats object has a bug in fetching name field
+    # TODO: Fix this super old bug when refactoring the underlying HDFS filesystem code
+    filename = os.path.basename(path) if request.fs._get_scheme(path).lower() in ('hdfs', 'ofs') else stats['name']
+
+    # Set the filename in the Content-Disposition header with proper encoding for special characters
+    encoded_filename = quote(filename)
+    response['Content-Disposition'] = f"{content_disposition}; filename*=UTF-8\'\'{encoded_filename}"
+
     response["Last-Modified"] = http_date(stats['mtime'])
     response["Content-Length"] = stats['size']