Skip to content

[ui-storagebrowser] refactor action component to extend for trash actions #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 3, 2025
Merged

[ui-storagebrowser] refactor action component to extend for trash actions #4023

merged 12 commits into from
Mar 3, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • Folder re-structuring for actions in storage browser.
  • Created a parent component for action, which will takes care of either rendering the trash actions or the regular actions.

How was this patch tested?

  • Updated unit test

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Mar 3, 2025
@ramprasadagarwal ramprasadagarwal marked this pull request as ready for review March 3, 2025 14:09
JohanAhlen
JohanAhlen approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) March 3, 2025 15:58
@ramprasadagarwal ramprasadagarwal merged commit 4c2d68a into master Mar 3, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-26 branch March 3, 2025 16:10
amitsrivastava pushed a commit that referenced this pull request Mar 10, 2025
@ramprasadagarwal @athithyaaselvam
CDPD-80129: [ui-storagebrowser] refactor action component to extend f…
bd2f9c6 
…or trash actions (#4023)

(cherry picked from commit 4c2d68a)
(cherry picked from commit 0c9963ce270de88a5cd0828e5ac6140a06c9527b)
athithyaaselvam pushed a commit that referenced this pull request Mar 11, 2025
@ramprasadagarwal @athithyaaselvam
[ui-storagebrowser] refactor action component to extend for trash act…
656da83 
…ions (#4023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @JohanAhlen @nidhibhatg