[ui-admin] disabled log out button for Knox #4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Backend Code Coverage Report •
Pytest Report
|
|
|
bjornalm
force-pushed
the
bjorn--conditionally-hide-logout-button
branch
from
0349b7d to
f5020b5
Compare
|
|
bjornalm
force-pushed
the
bjorn--conditionally-hide-logout-button
branch
from
f5020b5 to
6e1d943
Compare
|
|
bjornalm
requested review from
amitsrivastava,
ranade1,
Harshg999,
JohanAhlen and
ramprasadagarwal
bjornalm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I didn't find enough info in the config API so I had to rely on the URL variables.
@amitsrivastava can you verify that it is safe to depend on the global js variables like this and that the condition is complete?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.