Skip to content

[CI] Improve handling of comments when no test files are present in the commit #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Mar 25, 2025

What changes were proposed in this pull request?

  • This action will now check for changes in test files and comment only if no changes are found.
  • It will also prevent repeated comments.
  • Examples of test files: *test, _*tests, .test.

How was this patch tested?

  • Locally

Copy link

github-actions bot commented Mar 25, 2025

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL533162608651% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1101 107 💤 0 ❌ 0 🔥 5m 49s ⏱️

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and sweet! Nice one!

@agl29 agl29 changed the title Improve handling of comments when no test files are present in the commit [CI] Improve handling of comments when no test files are present in the commit Mar 25, 2025
@agl29 agl29 force-pushed the test-file-comment-action branch 3 times, most recently from 2a8c990 to eb4bcfe Compare March 25, 2025 10:58
@agl29 agl29 force-pushed the test-file-comment-action branch from eb4bcfe to 937c305 Compare March 25, 2025 11:02
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
@cloudera cloudera deleted a comment from github-actions bot Mar 25, 2025
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agl29 agl29 merged commit 4f591e7 into master Mar 25, 2025
8 checks passed
@agl29 agl29 deleted the test-file-comment-action branch March 25, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants