Skip to content

[ui-sb] Port sb from mako based to pure frontend #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • Moved the storage browser from mako based rendering to pure frontend.
  • Changed the URL from filebrowser/new to storagebrowser

How was this patch tested?

  • Manually tested

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Apr 26, 2025
Copy link

github-actions bot commented Apr 26, 2025

⚠️ No test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

github-actions bot commented Apr 26, 2025

Python Code Coverage

Python Coverage Report •
FileStmtsMissCoverMissing
apps/filebrowser/src/filebrowser
   views.py93861134%149, 156, 158–162, 164, 196–200, 210, 212–217, 219–224, 226, 229–234, 236, 238, 240–242, 244–249, 253, 259, 263, 294–296, 321–323, 327–329, 339, 341–343, 346, 348, 353, 358, 361, 367, 371, 373–375, 377, 389, 394–395, 398–399, 401–409, 411, 413, 415, 417, 425–428, 437–439, 441, 443–445, 447, 449–452, 454–455, 457–459, 461–465, 467–468, 488, 490–491, 493, 495, 497, 499, 501, 519, 522–524, 527–528, 530–531, 574, 580, 582, 585, 593, 596–598, 603–604, 611, 620–624, 636–637, 640–642, 687, 726, 728–731, 735, 737–748, 760, 762–763, 766–768, 770–771, 779–783, 785–790, 792, 794, 796–797, 799–806, 809–810, 812, 815–819, 821–822, 825–827, 830–831, 833, 835–837, 839–840, 850–852, 856–858, 860–861, 863–866, 870–871, 885–886, 888, 890–892, 895–913, 915, 917–926, 929, 932–933, 935, 939–943, 947–948, 950–951, 955, 959–962, 964–966, 968–971, 973–974, 976, 978–982, 1003–1011, 1015–1021, 1025–1032, 1037, 1042, 1048, 1057–1062, 1070–1071, 1073, 1078–1085, 1098–1099, 1101, 1103–1104, 1107, 1109, 1113–1118, 1128–1130, 1133–1140, 1142–1146, 1148, 1152, 1166, 1178, 1192, 1223, 1228, 1240–1245, 1247–1253, 1255–1261, 1265–1266, 1268–1270, 1272, 1275–1278, 1282, 1284–1291, 1293, 1297–1300, 1302, 1306, 1309–1311, 1313, 1317, 1320–1322, 1329, 1348–1349, 1351–1355, 1359, 1367–1368, 1370–1374, 1377–1378, 1380, 1383–1384, 1386, 1394, 1397, 1399–1402, 1405, 1416–1420, 1422–1423, 1425–1429, 1431, 1439–1440, 1442–1445, 1453, 1457, 1485–1487, 1489, 1491–1502, 1504–1507, 1509–1510, 1514–1515, 1526, 1541–1545, 1548–1549, 1552–1559, 1571–1576, 1587, 1589–1597, 1599, 1609–1610, 1612–1613, 1615–1618, 1620–1621, 1623–1633, 1635–1636, 1638, 1644, 1646, 1652–1655, 1657–1663, 1665, 1668, 1674–1678, 1680–1684, 1686, 1688, 1691, 1695–1696, 1703, 1710–1712, 1714, 1718–1719, 1723
desktop/core/src/desktop
   models.py124826578%107–109, 122, 127–129, 131, 149, 152, 223, 232, 256, 284, 294, 296–297, 299–300, 307, 312, 319, 350, 373, 389, 391, 401–402, 404, 412–418, 420, 422, 424–425, 428–429, 431, 447–448, 475, 477–478, 480–481, 483–488, 496–500, 508–510, 518–526, 528–529, 531, 533–535, 546, 548, 550, 554–555, 559–564, 567–570, 572–574, 576–579, 582–587, 591, 594–595, 597, 599–601, 611, 616–618, 629, 631–632, 635–636, 639–640, 643–644, 647, 650, 652–656, 682, 686, 690, 696, 717–718, 734, 751, 768, 776, 778, 780, 782, 784–785, 787, 789, 791–794, 796, 798–799, 801, 805–808, 811, 814, 860–861, 869, 878, 880, 882–884, 886, 888–890, 892, 894–895, 1069, 1128–1131, 1159–1161, 1252, 1291, 1304, 1306, 1312, 1318, 1320, 1323–1324, 1347, 1350, 1352–1356, 1358–1359, 1400, 1498, 1532, 1554–1556, 1632, 1733, 1793, 1836, 1846–1850, 1854–1855, 1863–1865, 1868, 1881, 1883, 1912–1913, 1938, 1971, 2008, 2017, 2040–2042, 2051–2053, 2063–2064, 2073–2075, 2084–2086, 2126, 2159, 2178, 2223, 2250, 2259, 2269, 2280, 2288, 2305, 2321–2326
TOTAL537132701149% 

Pytest Report

Tests Skipped Failures Errors Time
1090 106 💤 0 ❌ 0 🔥 5m 55s ⏱️

@ramprasadagarwal ramprasadagarwal requested review from nidhibhatg, bjornalm and tabraiz12 and removed request for nidhibhatg April 28, 2025 08:53
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning this up

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) May 5, 2025 08:59
@ramprasadagarwal ramprasadagarwal merged commit 0cf1851 into master May 5, 2025
7 of 8 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-41 branch May 5, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants