Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-352. Web UI. Added pagination by updating to use JQuery DataTables #326

Closed
wants to merge 1 commit into from

Conversation

ajbozarth
Copy link
Contributor

LIVY-352

Followup to #319 adding pagination and search by switching to use jQuery DataTables like the Spark Web UI.

none
both
sessions
batch

@codecov-io
Copy link

codecov-io commented May 9, 2017

Codecov Report

Merging #326 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #326      +/-   ##
============================================
- Coverage     70.67%   70.63%   -0.05%     
+ Complexity      716      715       -1     
============================================
  Files            96       96              
  Lines          5084     5087       +3     
  Branches        746      746              
============================================
  Hits           3593     3593              
- Misses          992      997       +5     
+ Partials        499      497       -2
Impacted Files Coverage Δ Complexity Δ
.../scala/com/cloudera/livy/server/ui/UIServlet.scala 2.56% <0%> (-0.22%) 1 <0> (ø)
.../java/com/cloudera/livy/rsc/rpc/RpcDispatcher.java 66.3% <0%> (-3.27%) 19% <0%> (-1%)
...la/com/cloudera/livy/scalaapi/ScalaJobHandle.scala 52.94% <0%> (-2.95%) 0% <0%> (ø)
...c/src/main/java/com/cloudera/livy/rsc/rpc/Rpc.java 78.61% <0%> (+0.62%) 12% <0%> (ø) ⬇️
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 77.15% <0%> (+0.86%) 39% <0%> (ø) ⬇️
rsc/src/main/java/com/cloudera/livy/rsc/Utils.java 85.71% <0%> (+2.38%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b206e...0cb6c91. Read the comment docs.

@ajbozarth
Copy link
Contributor Author

@zjffdu could you take a look at this and #327 since you requested these additions

@ajbozarth
Copy link
Contributor Author

@jerryshao could you also review this too?

@jerryshao
Copy link
Contributor

Sorry I'm not familiar with JQuery, trying to understand it 😄 .

LGTM from my poor knowledge of JS.

@jerryshao
Copy link
Contributor

Hi @ajbozarth , sorry for the delay, can you submit this PR against https://github.com/apache/incubator-livy, thanks.

@ajbozarth
Copy link
Contributor Author

Moved to apache/incubator-livy#3

@ajbozarth ajbozarth closed this Jun 28, 2017
@ajbozarth ajbozarth deleted the ui-pagination branch June 30, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants