-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVY-353. Web UI. Added link to Spark UI for Sessions running on Yarn #327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
============================================
- Coverage 70.67% 70.61% -0.06%
+ Complexity 716 715 -1
============================================
Files 96 96
Lines 5084 5084
Branches 746 746
============================================
- Hits 3593 3590 -3
- Misses 992 997 +5
+ Partials 499 497 -2
Continue to review full report at Codecov.
|
@jerryshao would you also review this as well? |
Sorry @ajbozarth for late response. The patch LGTM. |
Hi @ajbozarth , sorry for the delay, can you submit this PR against https://github.com/apache/incubator-livy, thanks. |
moved to apache/incubator-livy#4 |
PR moved from old repo cloudera/livy#327 [LIVY-353](https://issues.cloudera.org/browse/LIVY-353) Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created. Screenshots With an appId without link (in this case before the UI is generated):  With an appId link:  What it links to:  Author: Alex Bozarth <ajbozart@us.ibm.com> Closes #4 from ajbozarth/ui-app-link.
PR moved from old repo cloudera/livy#327 [LIVY-353](https://issues.cloudera.org/browse/LIVY-353) Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created. Screenshots With an appId without link (in this case before the UI is generated):  With an appId link:  What it links to:  Author: Alex Bozarth <ajbozart@us.ibm.com> Closes apache#4 from ajbozarth/ui-app-link.
LIVY-353
Followup to #319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.
Screenshots
With an appId without link (in this case before the UI is generated):



With an appId link:
What it links to: