Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-353. Web UI. Added link to Spark UI for Sessions running on Yarn #327

Closed
wants to merge 1 commit into from

Conversation

ajbozarth
Copy link
Contributor

LIVY-353

Followup to #319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.

Screenshots

With an appId without link (in this case before the UI is generated):
no-link
With an appId link:
link
What it links to:
spark

@codecov-io
Copy link

codecov-io commented May 9, 2017

Codecov Report

Merging #327 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
- Coverage     70.67%   70.61%   -0.06%     
+ Complexity      716      715       -1     
============================================
  Files            96       96              
  Lines          5084     5084              
  Branches        746      746              
============================================
- Hits           3593     3590       -3     
- Misses          992      997       +5     
+ Partials        499      497       -2
Impacted Files Coverage Δ Complexity Δ
.../java/com/cloudera/livy/rsc/rpc/RpcDispatcher.java 66.3% <0%> (-3.27%) 19% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b206e...d316f17. Read the comment docs.

@ajbozarth
Copy link
Contributor Author

@zjffdu could you take a look at this and #326 since you requested these additions

@ajbozarth
Copy link
Contributor Author

@jerryshao would you also review this as well?

@jerryshao
Copy link
Contributor

Sorry @ajbozarth for late response. The patch LGTM.

@jerryshao
Copy link
Contributor

Hi @ajbozarth , sorry for the delay, can you submit this PR against https://github.com/apache/incubator-livy, thanks.

@ajbozarth
Copy link
Contributor Author

moved to apache/incubator-livy#4

@ajbozarth ajbozarth closed this Jun 28, 2017
asfgit pushed a commit to apache/incubator-livy that referenced this pull request Jun 30, 2017
PR moved from old repo cloudera/livy#327

[LIVY-353](https://issues.cloudera.org/browse/LIVY-353)

Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.

Screenshots

With an appId without link (in this case before the UI is generated):
![no-link](https://cloud.githubusercontent.com/assets/13952758/25873597/0307dd40-34c4-11e7-9993-925cbf7c749b.png)
With an appId link:
![link](https://cloud.githubusercontent.com/assets/13952758/25873599/0454c69a-34c4-11e7-85d2-31ebe993c5a3.png)
What it links to:
![spark](https://cloud.githubusercontent.com/assets/13952758/25873602/05864318-34c4-11e7-8e2c-2222ef7f6116.png)

Author: Alex Bozarth <ajbozart@us.ibm.com>

Closes #4 from ajbozarth/ui-app-link.
@ajbozarth ajbozarth deleted the ui-app-link branch June 30, 2017 18:16
praveen-kanamarlapudi pushed a commit to praveen-kanamarlapudi/incubator-livy that referenced this pull request Jul 7, 2017
PR moved from old repo cloudera/livy#327

[LIVY-353](https://issues.cloudera.org/browse/LIVY-353)

Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.

Screenshots

With an appId without link (in this case before the UI is generated):
![no-link](https://cloud.githubusercontent.com/assets/13952758/25873597/0307dd40-34c4-11e7-9993-925cbf7c749b.png)
With an appId link:
![link](https://cloud.githubusercontent.com/assets/13952758/25873599/0454c69a-34c4-11e7-85d2-31ebe993c5a3.png)
What it links to:
![spark](https://cloud.githubusercontent.com/assets/13952758/25873602/05864318-34c4-11e7-8e2c-2222ef7f6116.png)

Author: Alex Bozarth <ajbozart@us.ibm.com>

Closes apache#4 from ajbozarth/ui-app-link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants