Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-357. Web UI. Updated staticResourceServlet to return 404s and not throw WARNs #330

Closed
wants to merge 2 commits into from

Conversation

ajbozarth
Copy link
Contributor

LIVY-357

Since #319 added the UI whenever a static resource is accessed a MimeException is thrown as a WARN. This was caused because a InputStream must be wrapped in a BufferedInputStream for a full implementation.

I updated staticResourceServlet with the wrapper as well as adding a 404 File not found return when a file does not exist (currently an empty file is returned in such a case)

Tested manually

@ajbozarth
Copy link
Contributor Author

@jerryshao figured out the bug you found

@jerryshao
Copy link
Contributor

LGTM, thanks for the fix. CC @zjffdu .

Can you please run the travis again?

@ajbozarth ajbozarth closed this May 15, 2017
@ajbozarth ajbozarth reopened this May 15, 2017
@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #330 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
- Coverage     70.42%   70.26%   -0.17%     
+ Complexity      726      724       -2     
============================================
  Files            96       96              
  Lines          5123     5129       +6     
  Branches        774      777       +3     
============================================
- Hits           3608     3604       -4     
- Misses          997     1007      +10     
  Partials        518      518
Impacted Files Coverage Δ Complexity Δ
...in/scala/com/cloudera/livy/server/LivyServer.scala 35.5% <0%> (-1.93%) 9 <0> (ø)
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 76.29% <0%> (-1.3%) 39% <0%> (-1%)
.../java/com/cloudera/livy/rsc/driver/JobWrapper.java 80.64% <0%> (ø) 7% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59af39d...d86463d. Read the comment docs.

@jerryshao
Copy link
Contributor

Ping @zjffdu , can you please review this PR please.

@jerryshao
Copy link
Contributor

Hi @ajbozarth , sorry for the delay, can you submit this PR against https://github.com/apache/incubator-livy, thanks.

@ajbozarth
Copy link
Contributor Author

Moved to apache/incubator-livy#2

@ajbozarth ajbozarth closed this Jun 28, 2017
@ajbozarth ajbozarth deleted the ui-error branch June 30, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants