Fixes code issues detected by golint

Author: Kris Kwiatkowski

Diff for: .etc/golangci.yml

@@ -3,7 +3,6 @@ linters:
   disable:
   - ineffassign
   - gocritic
-  - golint
   - stylecheck
   - errcheck
   - misspell

Diff for: dh/sidh/internal/common/types.go

@@ -2,37 +2,37 @@ package common
 
 const (
 	// corresponds to words in P751
-	FP_MAX_WORDS = 12
+	FpMaxWords = 12
 	// corresponds to byte size of P751 SIDH private key for B
-	MAX_SIDH_PRIVATE_KEY_BSZ = 48
+	MaxSidhPrivateKeyBsz = 48
 	// corresponds to byte size of P751 SIKE private key for B
-	MAX_SIKE_PRIVATE_KEY_BSZ = MAX_SIDH_PRIVATE_KEY_BSZ + MAX_MSG_BSZ
+	MaxSikePrivateKeyBsz = MaxSidhPrivateKeyBsz + MaxMsgBsz
 	// corresponds to SIKE max length of 'n' (see 1.4 of SIKE spec in NIST PQC round 1)
-	MAX_MSG_BSZ = 40
+	MaxMsgBsz = 40
 	// corresponds to byte size of shared secret generated by SIKEp751
-	MAX_SHARED_SECRET_BSZ = 188
+	MaxSharedSecretBsz = 188
 	// correponds to by size of the P751 public key
-	MAX_PUBLIC_KEY_SZ = 3 * FP_MAX_WORDS * 64
+	MaxPublicKeySz = 3 * FpMaxWords * 64
 	// correponds to by size of the ciphertext produced by SIKE/P751
-	MAX_CIPHERTEXT_BSZ = MAX_MSG_BSZ + MAX_PUBLIC_KEY_SZ
+	MaxCiphertextBsz = MaxMsgBsz + MaxPublicKeySz
 )
 
 // Id's correspond to bitlength of the prime field characteristic
-// Currently FP_751 is the only one supported by this implementation
+// Currently Fp751 is the only one supported by this implementation
 const (
-	FP_503 uint8 = iota
-	FP_751
+	Fp503 uint8 = iota
+	Fp751
 )
 
 // Representation of an element of the base field F_p.
 //
 // No particular meaning is assigned to the representation -- it could represent
 // an element in Montgomery form, or not.  Tracking the meaning of the field
 // element is left to higher types.
-type Fp [FP_MAX_WORDS]uint64
+type Fp [FpMaxWords]uint64
 
 // Represents an intermediate product of two elements of the base field F_p.
-type FpX2 [2 * FP_MAX_WORDS]uint64
+type FpX2 [2 * FpMaxWords]uint64
 
 // Represents an element of the extended field Fp^2 = Fp(x+i)
 type Fp2 struct {
@@ -42,7 +42,7 @@ type Fp2 struct {
 
 type DomainParams struct {
 	// P, Q and R=P-Q base points
-	Affine_P, Affine_Q, Affine_R Fp2
+	AffineP, AffineQ, AffineR Fp2
 	// Size of a compuatation strategy for x-torsion group
 	IsogenyStrategy []uint32
 	// Max size of secret key for x-torsion group
@@ -52,7 +52,7 @@ type DomainParams struct {
 }
 
 type SidhParams struct {
-	Id uint8
+	ID uint8
 	// Bytelen of P
 	Bytelen int
 	// The public key size, in bytes.