Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkin go.sum #24

Closed
mmcloughlin opened this issue Jun 4, 2019 · 3 comments · Fixed by #25
Closed

Checkin go.sum #24

mmcloughlin opened this issue Jun 4, 2019 · 3 comments · Fixed by #25
Assignees
@kriskwiatkowski

Comments

@mmcloughlin
Copy link
Contributor

Generally, go.sum should be checked in with go.mod.

https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file
@kriskwiatkowski
Copy link
Contributor

@mmcloughlin Good point. I'll add it (except if you want to do it).

@mmcloughlin
Copy link
Contributor Author

Go ahead. I just noticed and thought I'd point it out.

@kriskwiatkowski
Copy link
Contributor

kriskwiatkowski commented Jun 4, 2019 •
edited
Loading

thanks for noticing

@kriskwiatkowski kriskwiatkowski self-assigned this Jun 4, 2019
mmcloughlin added a commit that referenced this issue Jun 5, 2019
@mmcloughlin
add go.sum file
3c8ba6c 
Adds the go.sum file as recommended in Go modules documentation.

https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file

Fixes #24
@mmcloughlin mmcloughlin mentioned this issue Jun 5, 2019
Merged
armfazh pushed a commit that referenced this issue Jun 5, 2019
@mmcloughlin @armfazh
add go.sum file
b913916 
Adds the go.sum file as recommended in Go modules documentation.

https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file

Fixes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskwiatkowski kriskwiatkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add go.sum cloudflare/circl
2 participants
@kriskwiatkowski @mmcloughlin