Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cSHAKE or reimplement SHA-3 #5

Closed
kriskwiatkowski opened this issue Mar 19, 2019 · 1 comment · Fixed by #48
Closed

Remove cSHAKE or reimplement SHA-3 #5

kriskwiatkowski opened this issue Mar 19, 2019 · 1 comment · Fixed by #48
Assignees
@kriskwiatkowski

Comments

@kriskwiatkowski
Copy link
Contributor

Currently cSHAKE uses SHA-3. Code of SHA-3 was imported from golang (as implementing cSHAKE on top of public interfaces was hard/impossible to do).
cSHAKE is needed only for current version of SIKE. Nevertheless, it shouldn't be needed in the future, which means we don't need to keep copy of SHA-3 in CIRCL.
@kriskwiatkowski kriskwiatkowski self-assigned this Mar 19, 2019
@kriskwiatkowski
Copy link
Contributor Author

kriskwiatkowski commented Apr 17, 2019 •
edited
Loading

I've finally managed to upstream cSHAKE to x/crypto, so SHA-3 is now really not needed in CIRCL
Looking at the SHA-3 code in x/crypto more deeply I would prefer we re-write it. Code has some fundamental issues. Keccak part looks OK, so it can be reused

@kriskwiatkowski kriskwiatkowski mentioned this issue Jun 19, 2019
Merged
@UladzimirTrehubenka UladzimirTrehubenka mentioned this issue Jul 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskwiatkowski kriskwiatkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves /hash/sha3 to dh/sidh/internal/shake cloudflare/circl
1 participant
@kriskwiatkowski