Enable linters: deadcode, varcheck, unused #37
Conversation
dh/sidh/sidh_test.go
Outdated
| @@ -262,43 +261,6 @@ func testImportExport(t *testing.T, v sidhVec) { | |||
| } | |||
| } | |||
|
|
|||
| func testPrivateKeyBelowMax(t testing.TB, id uint8) { | |||
There was a problem hiding this comment.
Was this supposed to be used somewhere?
There was a problem hiding this comment.
yes, it's needed. but it was disabled
#38
ecc/p384/arith_amd64.go
Outdated
| @@ -5,3 +5,6 @@ package p384 | |||
| import "golang.org/x/sys/cpu" | |||
|
|
|||
| var hasBMI2 = cpu.X86.HasBMI2 | |||
|
|
|||
| // Avoid deadcode lint error since this is only accessed from assembly. | |||
| var _ = hasBMI2 | |||
There was a problem hiding this comment.
This is a bit ugly, but I personally think it's worth it to catch genuine instances of dead code.
There was a problem hiding this comment.
One solution for that is to access the cpu.X86.HasBMI2 variable directly in the assembly file. Do you know the propoer syntax to do it?
There was a problem hiding this comment.
As HasBMI2 is a field in a struct, seems to me you need to do something like:
golang·org∕x∕sys∕cpu·X86+const_offsetX86HasBMI2(SB)
where const_offsetX86HasBMI2 is const offsetX86HasBMI2 = unsafe.Offsetof(cpu.X86.HasBMI2)
so you need to store the offset somewhere anyway. Using hardcoded value for offset is out of scope for obvious reasons.
Assuming I'm not wrong there are 3 solutions:
- Leave it as it is.
- Have a code internally which calculates those offsets.
- Implement calculation of those offsets in the golang.org/x/sys/cpu
Ideally I would like to have 3 (or even better if golang itself simply exports those values). If not then 2, but that's not a short term solution. So I guess we are left with 1.
kriskwiatkowski
force-pushed
the
lint-enable-deadcode
branch
from
fba37e9 to
212e5af
Compare
This diff enables linters that check for dead code and unused variables.
Updates #26