Skip to content

Update batched f91a to 0005 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

thibmeu
Copy link
Contributor

@thibmeu thibmeu commented Feb 9, 2025

Batched tokens token type is now 0x0005

Update following change in draft from draft 04 to draft 05 (to be published).

Relates to ietf-wg-privacypass/ietf-draft-privacypass-batched-tokens/pull/27

@thibmeu thibmeu added the enhancement New feature or request label Feb 9, 2025
@thibmeu thibmeu self-assigned this Feb 9, 2025
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this pull request Feb 9, 2025
Changed in ietf-wg-privacypass#27. Tests vectors have been regenerated in the Go
implementation using cloudflare/pat-go#50
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this pull request Feb 9, 2025
Changed in ietf-wg-privacypass#27. Tests vectors have been regenerated in the Go
implementation using cloudflare/pat-go#50
@thibmeu
Copy link
Contributor Author

thibmeu commented Feb 9, 2025

This commit also removes Rust imported test vectors, which are not up-to-date yet. I'm also not sure how they have been generated.

cc @raphaelrobert

Length is encoded as an RFC 9000 varint
The outter layer is a quicvarint. This commit updates the code and the
tests
@thibmeu thibmeu requested a review from armfazh March 4, 2025 09:55
Copy link
Collaborator

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please rework on using the stdlib code.

@thibmeu thibmeu requested a review from armfazh March 5, 2025 17:00
Copy link
Collaborator

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run go mod tidy to remove the quic-go dependency, and is good to go.

@thibmeu thibmeu merged commit f850223 into cloudflare:main Mar 6, 2025
2 checks passed
@thibmeu thibmeu deleted the update-batched-f91a-to-0005 branch March 6, 2025 08:46
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this pull request Mar 28, 2025
Changed in ietf-wg-privacypass#27. Tests vectors have been regenerated in the Go
implementation using cloudflare/pat-go#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants