feat: apply event rule update

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
cloudforet-io · Jan 8, 2025 · f934a18 · f934a18
1 parent ed68a1f
commit f934a18
Show file tree

Hide file tree

Showing 13 changed files with 427 additions and 250 deletions.
diff --git a/apps/web/src/services/alert-manager/components/ServiceDetailTabsSettingsEventRule.vue b/apps/web/src/services/alert-manager/components/ServiceDetailTabsSettingsEventRule.vue
@@ -2,17 +2,13 @@
 import { computed, reactive, watch } from 'vue';
 import { useRoute } from 'vue-router/composables';
 
-import { SpaceConnector } from '@cloudforet/core-lib/space-connector';
 import { PButton, PDataLoader } from '@cloudforet/mirinae';
 
-import type { EventRuleGetParameters } from '@/schema/alert-manager/event-rule/api-verbs/get';
 import { EVENT_RULE_SCOPE } from '@/schema/alert-manager/event-rule/constant';
 import type { EventRuleModel } from '@/schema/alert-manager/event-rule/model';
 
 import { replaceUrlQuery } from '@/lib/router-query-string';
 
-import ErrorHandler from '@/common/composables/error/errorHandler';
-
 import ServiceDetailTabsSettingsEventRuleCard
     from '@/services/alert-manager/components/ServiceDetailTabsSettingsEventRuleCard.vue';
 import ServiceDetailTabsSettingsEventRuleFormCard
@@ -33,15 +29,15 @@ const storeState = reactive({
     modalVisible: computed<boolean>(() => serviceDetailPageState.eventRuleScopeModalVisible),
     items: computed<EventRuleModel[]>(() => serviceDetailPageState.eventRuleList),
     showEventRuleFormCard: computed<boolean>(() => serviceDetailPageState.showEventRuleFormCard),
+    isEventRuleEditMode: computed<boolean>(() => serviceDetailPageState.isEventRuleEditMode),
+    eventRuleInfo: computed<EventRuleModel>(() => serviceDetailPageState.eventRuleInfo),
 });
 const state = reactive({
     loading: true,
     eventRuleInfoLoading: false,
     selectedScope: EVENT_RULE_SCOPE.GLOBAL,
     selectedWebhook: '',
     hideSidebar: false,
-    eventRule: {} as EventRuleModel,
-    isEditMode: false,
 });
 
 const handleClickAddRule = () => {
@@ -51,16 +47,14 @@ const handleClickAddRule = () => {
 const fetchEventRuleInfo = async () => {
     state.eventRuleInfoLoading = true;
     try {
-        state.eventRule = await SpaceConnector.clientV2.alertManager.eventRule.get<EventRuleGetParameters, EventRuleModel>({
+        await serviceDetailPageStore.fetchEventRuleInfo({
             event_rule_id: route.query?.eventRuleId as string,
         });
-    } catch (e) {
-        ErrorHandler.handleError(e);
-        state.eventRule = {} as EventRuleModel;
     } finally {
         state.eventRuleInfoLoading = false;
     }
 };
+
 watch(() => route.query?.eventRuleId, (eventRuleId) => {
     if (eventRuleId) {
         fetchEventRuleInfo();
@@ -97,17 +91,13 @@ watch(() => storeState.serviceId, async (id) => {
                                                                  :items="storeState.items"
                 />
                 <service-detail-tabs-settings-event-rule-form-card v-if="storeState.showEventRuleFormCard"
-                                                                   :selected-webhook="state.isEditMode ? state.eventRule.webhook_id : state.selectedWebhook"
-                                                                   :selected-scope="state.isEditMode ? state.eventRule.scope : state.selectedScope"
-                                                                   :event-rule="state.eventRule"
-                                                                   :is-edit-mode="state.isEditMode"
+                                                                   :selected-webhook="storeState.isEventRuleEditMode ? storeState.eventRuleInfo.webhook_id : state.selectedWebhook"
+                                                                   :selected-scope="storeState.isEventRuleEditMode ? storeState.eventRuleInfo.scope : state.selectedScope"
                                                                    class="flex-1"
                 />
-                <service-detail-tabs-settings-event-rule-card v-else-if="state.eventRule.event_rule_id"
+                <service-detail-tabs-settings-event-rule-card v-else-if="storeState.eventRuleInfo.event_rule_id"
                                                               class="flex-1"
-                                                              :event-rule="state.eventRule"
                                                               :loading="state.eventRuleInfoLoading"
-                                                              :is-edit-mode.sync="state.isEditMode"
                 />
             </div>
             <template #no-data>