Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display user-add Modal after creating workspace and add condition #5396

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Jan 3, 2025

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

kkdy21 added 2 commits January 2, 2025 17:12
Signed-off-by: daeyeon ko <rowan@megazone.com>
Signed-off-by: daeyeon ko <rowan@megazone.com>
@kkdy21 kkdy21 requested a review from sulmoJ January 3, 2025 05:32
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-web ❌ Failed (Inspect) Jan 3, 2025 5:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 5:52am

Copy link

vercel bot commented Jan 3, 2025

Deployment failed with the following error:

Preview deployments are disabled for this project.

Copy link

vercel bot commented Jan 3, 2025

@kkdy21 is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@sulmoJ sulmoJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEEEEEEEEAAAAN

Signed-off-by: daeyeon ko <rowan@megazone.com>
@kkdy21 kkdy21 merged commit 66041a6 into cloudforet-io:refactor/user-add Jan 3, 2025
4 of 7 checks passed
kkdy21 added a commit that referenced this pull request Jan 3, 2025
#5396) (#5398)

* fix: user add conditions



* fix: display user-add Modal after creating workspace



* fix: conditional restoration for variable 'isNew'



---------

Signed-off-by: daeyeon ko <rowan@megazone.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants