Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-content-transformer): update editor content transformer and notice popup item to update only changed #5448

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

WANZARGEN
Copy link
Member

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

…time

Signed-off-by: Wanjin Noh <wanjin@megazone.com>
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 9:54am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 9:54am

Copy link

vercel bot commented Jan 7, 2025

@WANZARGEN is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

⚠️ @WANZARGEN the signed-off-by was not found in the following 1 commits:

  • 6cd8cc5: Revert "feat(file-download-helper): update download URL construction for Excel files"

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@WANZARGEN WANZARGEN merged commit 2a7a51d into cloudforet-io:master Jan 7, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant