Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mta): Ensure apps can be staged in air gapped environments #3490

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

silvestre
Copy link
Member

Issue

If the default version of the Go toolchain in the Go buildpack was not sufficient for the code to compile, during staging a call to the internet would be made to download the appropriate version. This would fail in air gapped environments.

Fix

Set GOTOOLCHAIN=local and the appropriate GOVERSION

@silvestre silvestre assigned silvestre and unassigned silvestre Feb 3, 2025
@silvestre silvestre marked this pull request as ready for review February 3, 2025 16:09
@silvestre silvestre enabled auto-merge (rebase) February 3, 2025 16:32
@silvestre silvestre disabled auto-merge February 4, 2025 08:15
@silvestre silvestre enabled auto-merge (squash) February 4, 2025 08:16
# Issue

If the default version of the Go toolchain in the Go buildpack was not
sufficient for the code to compile, during staging a call to the
internet would be made to download the appropriate version. This would
fail in air gapped environments.

# Fix

Set `GOTOOLCHAIN=local` and the appropriate `GOVERSION`
Copy link

sonarqubecloud bot commented Feb 4, 2025

@silvestre silvestre changed the title feat(mta): Ensure apps are able to be staged in air gapped environments fix(mta): Ensure apps can be staged in air gapped environments Feb 4, 2025
@silvestre silvestre added the bug label Feb 4, 2025
@silvestre silvestre merged commit f7dfe46 into main Feb 4, 2025
32 of 34 checks passed
@silvestre silvestre deleted the air-gapped-staging branch February 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants