Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang version to 1.23.1 #3518

Conversation

app-autoscaler-ci-bot
Copy link
Contributor

Automatic version bump of golang to 1.23.1
Package commit sha: a9fb0b9e97efd76f88253f78cf603403469d061e

silvestre and others added 2 commits February 13, 2025 15:04
# Issue

We previously used ASDF to manage our dev environment but meanwhile switched to devbox.

As the `devbox.json` was previously not kept up-to-date by renovate we kept ASDF's `.tool-version` files around for some handbuilt automation.

As devbox is now supported by renovate we can remove the left-overs.

# Fix

Remove all `.tool-versions` and automation built on it.
@app-autoscaler-ci-bot app-autoscaler-ci-bot added the dependencies Pull requests that update a dependency file label Feb 13, 2025
@silvestre
Copy link
Member

Successful test of #3515 - closing for now

@silvestre silvestre closed this Feb 13, 2025
bundler-cache: true
enable-cache: 'true'
- name: Make devbox shellenv available
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:13: Double quote to prevent globbing and word splitting [shellcheck]

@@ -50,15 +49,15 @@ jobs:
- name: Get ginkgo version from autoscaler-release
id: ginkgo
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]

version=$(grep "ginkgo " .tool-versions| cut -f 2 -d " ")
echo "GINKGO version from .tool-versions: \'${version}\'"
version=$(devbox info ginkgo | head --lines=1 | cut --field=2 --delimiter=" ")
echo "GINKGO version from devbox: \'${version}\'"
echo "version=${version}" >> "$GITHUB_OUTPUT"

- id: get-golang-version
shell: bash
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]

@silvestre silvestre deleted the golang-version-bump-1-23-1_a9fb0b9e97efd76f88253f78cf603403469d061e branch February 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants