-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang version to 1.23.1 #3518
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,10 @@ on: | |
paths: | ||
- 'ci/dockerfiles/**' | ||
- '.github/workflows/image.yml' | ||
- '.tool-versions' | ||
pull_request: | ||
paths: | ||
- 'ci/dockerfiles/**' | ||
- '.github/workflows/image.yml' | ||
- '.tool-versions' | ||
workflow_dispatch: | ||
|
||
env: | ||
|
@@ -20,6 +18,7 @@ env: | |
jobs: | ||
build-and-push-image: | ||
runs-on: ubuntu-latest | ||
container: jetpackio/devbox:latest@sha256:3e9b26747056d019dcedf295604a9b42dfe5a3b326fcc76de712b54a674314bd | ||
permissions: | ||
contents: read | ||
packages: write | ||
|
@@ -50,15 +49,15 @@ jobs: | |
- name: Get ginkgo version from autoscaler-release | ||
id: ginkgo | ||
run: | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 [actionlint] reported by reviewdog 🐶 |
||
version=$(grep "ginkgo " .tool-versions| cut -f 2 -d " ") | ||
echo "GINKGO version from .tool-versions: \'${version}\'" | ||
version=$(devbox info ginkgo | head --lines=1 | cut --field=2 --delimiter=" ") | ||
echo "GINKGO version from devbox: \'${version}\'" | ||
echo "version=${version}" >> "$GITHUB_OUTPUT" | ||
|
||
- id: get-golang-version | ||
shell: bash | ||
run: | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 [actionlint] reported by reviewdog 🐶 |
||
version=$(grep "golang " .tool-versions| cut -f 2 -d " ") | ||
echo "Go version from .tool-versions: \'${version}\'" | ||
version=$(devbox info go | head --lines=1 | cut --field=2 --delimiter=" ") | ||
echo "Go version from devbox: \'${version}\'" | ||
echo "version=${version}" >> "$GITHUB_OUTPUT" | ||
|
||
- name: Build and push | ||
|
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module apitester | ||
|
||
go 1.23.0 | ||
go 1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:13: Double quote to prevent globbing and word splitting [shellcheck]