Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Limit name of Plugin ReleaseNames to 53 characters #905

Open
4 tasks
IvoGoman opened this issue Feb 17, 2025 · 0 comments
Open
4 tasks

[FEAT] - Limit name of Plugin ReleaseNames to 53 characters #905

IvoGoman opened this issue Feb 17, 2025 · 0 comments
Labels
feature question Further information is requested

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Feb 17, 2025

Priority

(Medium) I'm annoyed but I'll live

User Story

As a Plugin admin I would like to have PluginPresets for different environments/ stages, so that the configuration does not get too complex and I can easily stage Plugin rollouts in the future.

Description

The name of a Plugin created by a PluginPreset is a concatenation of the PluginPreset name and the target cluster such as <pluginPreset>-<clusterName>.
PluginPresets are used to deploy the same PluginDefinition to a set of clusters. Instead of configuring all environments e.g. compute, storage etc. clusters in a bronze stage in one PluginPreset, the configuration should be done in several PluginPresets e.g. sample-preset-compute-bronze
With this a Plugin deployed to cc-az1-eu-de-1 would be called kube-monitoring-compute-bronze-cc-az1-eu-de-1. This is already 48 characters and Helm is limiting the release name to 53 characters. Currently the Plugin name is used as the name for the Helm Release, which has no length validation.

The Release name should be specc'able in the PluginPreset & Plugin, so that values generated and used between Plugins are stable.
One thing to consider is that two PluginPresets/Plugins deploying to the same cluster(s) should not use the same releaseName & namespace for the same PluginDefinition, as this will cause reconciliation loops since the configuration will differ.

To reduce the disruption of existing Plugins it needs to be ensured that the releaseName of existing Plugins are honoured and persisted. Otherwise, Helm Release will be reinstalled and existing releases will be abandoned.

Acceptance Criteria

  • Plugin`s ReleaseName must be limited to max 53 characters
  • Plugin ReleaseName must be stable and predictable, as they are used between Plugins
  • PluginPreset and Plugin should be able to define a .spec.releaseName to have a fixed releaseName
  • Release names of existing Plugins should have precedence

Reference Issues

No response

@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Feb 17, 2025
@IvoGoman IvoGoman added the question Further information is requested label Feb 17, 2025
@IvoGoman IvoGoman changed the title [FEAT] - Generated Names for Plugins created by PluginPresets [FEAT] - Limit name of Plugin ReleaseNames to 53 characters Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature question Further information is requested
Projects
Status: Sprint Backlog
Development

No branches or pull requests

1 participant