Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI Escape Sequences Populating in Geodesic with Atmos 1.158.0 #1035

Closed
RoseSecurity opened this issue Feb 6, 2025 · 3 comments
Closed
Labels
bug 🐛 An issue with the system

Comments

@RoseSecurity
Copy link
Contributor

Describe the Bug

  • ANSI escape sequences are populating in Geodesic when upgrading from Atmos 1.157.0 to 1.158.0 for every Atmos command
 √ . [infra] (HOST) workspace ⨠ atmos version

 █████  ████████ ███    ███  ██████  ███████
██   ██    ██    ████  ████ ██    ██ ██
███████    ██    ██ ████ ██ ██    ██ ███████
██   ██    ██    ██  ██  ██ ██    ██      ██
██   ██    ██    ██      ██  ██████  ███████


👽 Atmos 1.158.0 on linux/arm64

^[]11;rgb:1616/1818/1a1a^[\^[[49;1R ⧉  Locally Built Docker Image (infra)
 √ . [infra] (HOST) workspace ⨠ 10;rgb:ffff/ffff/ffff;1R11;rgb:1616/1818/1a1a;1R

Expected Behavior

  • The output of command should not contain ANSI sequences
 √ . [infra] (HOST) workspace ⨠ atmos version

 █████  ████████ ███    ███  ██████  ███████
██   ██    ██    ████  ████ ██    ██ ██
███████    ██    ██ ████ ██ ██    ██ ███████
██   ██    ██    ██  ██  ██ ██    ██      ██
██   ██    ██    ██      ██  ██████  ███████


👽 Atmos 1.158.0 on linux/arm64

Steps to Reproduce

  • Upgrade from Atmos 1.157.0 to 1.158.0
  • Build Geodesic
  • Run an Atmos command

Screenshots

No response

Environment

  • Geodesic v3.4.0 and v4.0.0

Additional Context

No response

@RoseSecurity RoseSecurity added the bug 🐛 An issue with the system label Feb 6, 2025
@osterman
Copy link
Member

osterman commented Feb 6, 2025

This was first reported in #1026 and caused when logs.file is set to /dev/stdout, I believe. It should never have been /dev/stdout as that will cause problems with any command that produces structured output (e.g. JSON), like in atmos describe * commands

This was fixed in:

Relates to:

@osterman
Copy link
Member

osterman commented Feb 6, 2025

These changes were released in v1.160.2.

@osterman
Copy link
Member

osterman commented Feb 6, 2025

Please re-open if you're still having the problem

@osterman osterman closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

2 participants