Update atmos schema #4662
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (15)
internal/exec/validate_stacks.go|388 col 28| hugeParam: atmosConfig is heavy (5704 bytes); consider passing it by pointer (gocritic)
internal/exec/validate_stacks.go|108 col 2| ifElseChain: rewrite if-else to switch statement (gocritic)
pkg/schema/schema.go|87 col 2| rangeValCopy: each iteration copies 152 bytes (consider pointers or indexing) (gocritic)
internal/exec/validate_stacks.go|387 col 1| Comment should end in a period (godot)
pkg/schema/schema.go|10 col 1| Comment should end in a period (godot)
pkg/schema/schema.go|70 col 1| Comment should end in a period (godot)
pkg/config/utils.go|329 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|337 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|345 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|353 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|475 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|481 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|487 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|493 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
pkg/config/utils.go|499 col 3| SA1019: u.LogDebug is deprecated: Use log.Debug
instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Filtered Findings (0)
Annotations
Check failure on line 388 in internal/exec/validate_stacks.go
github-actions / golangci
[golangci] internal/exec/validate_stacks.go#L388
hugeParam: atmosConfig is heavy (5704 bytes); consider passing it by pointer (gocritic)
Raw output
internal/exec/validate_stacks.go:388:28: hugeParam: atmosConfig is heavy (5704 bytes); consider passing it by pointer (gocritic)
func downloadSchemaFromURL(atmosConfig schema.AtmosConfiguration) (string, error) {
^
Check failure on line 108 in internal/exec/validate_stacks.go
github-actions / golangci
[golangci] internal/exec/validate_stacks.go#L108
ifElseChain: rewrite if-else to switch statement (gocritic)
Raw output
internal/exec/validate_stacks.go:108:2: ifElseChain: rewrite if-else to switch statement (gocritic)
if manifestSchema.Manifest == "" {
^
Check failure on line 87 in pkg/schema/schema.go
github-actions / golangci
[golangci] pkg/schema/schema.go#L87
rangeValCopy: each iteration copies 152 bytes (consider pointers or indexing) (gocritic)
Raw output
pkg/schema/schema.go:87:2: rangeValCopy: each iteration copies 152 bytes (consider pointers or indexing) (gocritic)
for key, node := range aux.Schemas {
^
Check failure on line 387 in internal/exec/validate_stacks.go
github-actions / golangci
[golangci] internal/exec/validate_stacks.go#L387
Comment should end in a period (godot)
Raw output
internal/exec/validate_stacks.go:387:1: Comment should end in a period (godot)
// downloadSchemaFromURL downloads the Atmos JSON Schema file from the provided URL
^
Check failure on line 10 in pkg/schema/schema.go
github-actions / golangci
[golangci] pkg/schema/schema.go#L10
Comment should end in a period (godot)
Raw output
pkg/schema/schema.go:10:1: Comment should end in a period (godot)
// AtmosConfiguration structure represents schema for `atmos.yaml` CLI config
^
Check failure on line 70 in pkg/schema/schema.go
github-actions / golangci
[golangci] pkg/schema/schema.go#L70
Comment should end in a period (godot)
Raw output
pkg/schema/schema.go:70:1: Comment should end in a period (godot)
// Custom YAML unmarshaler for `Schemas`
^
Check failure on line 329 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L329
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:329:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Found ENV var ATMOS_SCHEMAS_JSONSCHEMA_BASE_PATH=%s", jsonschemaBasePath))
^
Check failure on line 337 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L337
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:337:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Found ENV var ATMOS_SCHEMAS_OPA_BASE_PATH=%s", opaBasePath))
^
Check failure on line 345 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L345
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:345:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Found ENV var ATMOS_SCHEMAS_CUE_BASE_PATH=%s", cueBasePath))
^
Check failure on line 353 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L353
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:353:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Found ENV var ATMOS_SCHEMAS_ATMOS_MANIFEST=%s", atmosManifestJsonSchemaPath))
^
Check failure on line 475 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L475
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:475:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Using command line argument '%s=%s'", InitRunReconfigure, configAndStacksInfo.InitRunReconfigure))
^
Check failure on line 481 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L481
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:481:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Using command line argument '%s' as JsonSchema schemas directory", configAndStacksInfo.JsonSchemaDir))
^
Check failure on line 487 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L487
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:487:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Using command line argument '%s' as OPA schemas directory", configAndStacksInfo.OpaDir))
^
Check failure on line 493 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L493
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:493:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Using command line argument '%s' as CUE schemas directory", configAndStacksInfo.CueDir))
^
Check failure on line 499 in pkg/config/utils.go
github-actions / golangci
[golangci] pkg/config/utils.go#L499
SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
Raw output
pkg/config/utils.go:499:3: SA1019: u.LogDebug is deprecated: Use `log.Debug` instead. This function will be removed in a future release. LogDebug logs the provided debug message (staticcheck)
u.LogDebug(fmt.Sprintf("Using command line argument '%s' as path to Atmos JSON Schema", configAndStacksInfo.AtmosManifestJsonSchema))
^