Equipping Bandage Roll With Full Inventory Destroys Excess Bandages

[cm13-issue-bot]

Testmerges

#8959: 'Speech bubble update' by Blundir at commit 42361441ef
#7703: 'Hivelord Strain: Designer [Ver. 0.7]' by Venuska1117 at commit 7a219954d2
#9034: 'lurker rework, Pounce changes, invis decreased on pounce/damage' by private-tristan at commit 1d19e5a4bb
#8963: 'Ports tacmap port from PVE' by Git-Nivrak at commit bbb5c4c7d6
#9040: 'New In_hands and On_mobs (IDs, Backpacks, Belts, Swords and Knives)' by LC4492 at commit da5820b1c6
#9054: 'Rspack port' by Kashargul at commit e277971810
#9144: 'disables cade building after alamo smacks into almayer (HIJACK)' by psyendrocronologicalwarfare at commit 75f04f9f8f
#9151: 'fixes the orbit menu when someone's not wearing an id' by hry-gh at commit 1337b4e7e8

Round ID

27491

Description of the bug

When equipping a bandage roll in your hand, CM now merges the bandage charges with whatever bandage is in your inventory. When you 'merge' these stacks via equipping but the stack you are equipping has more charges than what would create a 10 stack in your inventory after being added, the excess bandages are deleted if there is nowhere else for the excess bandages to go to in your inventory.

What's the difference with what should have happened?

Items should not magically be deleted and what is more, a LOT of bandages are merged throughout an average round. This bug deletes many, many bandages over the course of a round. If you have space in your inventory the excess bandages go there but many people run around with full inventories.

How do we reproduce this bug?

Using simple numbers here:

1. Have a full inventory with a stack of 9 bandages in your webbing.
2. Have a new stack of 10 bandages in your hand.
3. Equip the bandages to merge the new stack with the stack in your webbing.
4. Notice your webbing stack is now full and the stack from your hand is gone, in this case 9 entire bandages were deleted.

Attached logs

N/A

Additional details

• Author: Superwelder
• Admin: SmellyHippie
• Note: None