Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO Policy for bots? #352

Closed
vsoch opened this issue May 25, 2022 · 4 comments
Closed

DCO Policy for bots? #352

vsoch opened this issue May 25, 2022 · 4 comments

Comments

@vsoch
Copy link

vsoch commented May 25, 2022

Hey CNCF!

We added a small contributors bot to our repository, and he basically looks for new contributors to the code, and then opens a pull request to update a metadata file and a pretty rendering in the README.md so we can put contributors front and center.

However, after his first run I realized that his PRs will never be acceptable because the GitHub bot cannot sign the commits (and thus pass the DCO check). An example is here: https://github.com/oras-project/oras-py/pull/18/checks?check_run_id=6585218827

We currently have that workflow disabled until further discussion about what we might do. I was pointed here to y'all and I thought you might have a good idea, e.g., how have other projects that want a bot to do some automation handled this issue?

ping @sajayantony

Thank you!

@dims
Copy link
Member

dims commented May 26, 2022

@caniszczyk
Copy link
Contributor

caniszczyk commented May 26, 2022 via email

@vsoch
Copy link
Author

vsoch commented May 26, 2022

oh wow, that's a very simple solution! Indeed I will try that and report back. Thanks @dims and @caniszczyk !

@vsoch
Copy link
Author

vsoch commented May 26, 2022

Worked like a charm! For future readers of this post, what I wound up doing it:

git commit -a -m "Automated deployment to update contributors ${today}" -m "Signed-off-by: github-actions <github-actions@users.noreply.github.com>"

If you do a newline in -m it's not honored (and won't work) and neither will using a name / email that is not the actual author of the commit.

Thank you again!

@vsoch vsoch closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@dims @caniszczyk @vsoch and others