-
Notifications
You must be signed in to change notification settings - Fork 88
feat: Add unit tests for SplitRecursively function #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unit tests for SplitRecursively function #348
Conversation
FranFigueroa
commented
Apr 19, 2025
Adds unit tests covering basic functionality, overlap, whitespace trimming, and discarding empty chunks for the SplitRecursively function. Includes TODOs noting potential inconsistencies observed during testing regarding overlap and whitespace handling for further investigation. Closes cocoindex-io#34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making this PR! Really appreciate the effort!
Would you mind translating the comments to English? Since English is used throughout codebase of this project. Thanks!
|
2e10170
to
6b75569
Compare
My apologies for missing those earlier! I've removed non-English comments. The code should now only contains comments in english, as requested. Please let me know if everything looks good now or if there's anything else needed. Thanks! |
6b75569
to
a372f41
Compare
a372f41
to
98a0f3c
Compare
@FranFigueroa we just published release note and made a section for you https://cocoindex.io/blogs/cocoindex-changelog-2025-04-30#franfigueroa. we love your contribution and welcome to the community! |