Experiment with even more optimizations

Author: joshsmith

Diff for: lib/code_corps_web/controllers/project_controller.ex

@@ -45,9 +45,9 @@ defmodule CodeCorpsWeb.ProjectController do
   end
 
   @preloads [
-    :donation_goals, [organization: :stripe_connect_account],
+    :donation_goals, [organization: [:organization_github_app_installations, :projects, :slugged_route, :stripe_connect_account]],
     :project_categories, :project_github_repos, :project_skills,
-    :project_users, :stripe_connect_plan, :task_lists, :tasks
+    [project_users: :user], :stripe_connect_plan, :task_lists, :tasks
   ]
 
   def preload(data) do

Diff for: lib/code_corps_web/controllers/task_list_controller.ex

@@ -28,7 +28,7 @@ defmodule CodeCorpsWeb.TaskListController do
     end
   end
 
-  @preloads [tasks: [:github_issue, :github_pull_request, :task_skills, :user, :user_task]]
+  @preloads [tasks: [:github_issue, :github_pull_request, :task_skills, :user, [user_task: :user]]]
 
   def preload(data) do
     Repo.preload(data, @preloads)

Diff for: lib/code_corps_web/views/project_user_view.ex

@@ -6,5 +6,5 @@ defmodule CodeCorpsWeb.ProjectUserView do
   attributes [:role, :inserted_at, :updated_at]
 
   has_one :project, type: "project", field: :project_id
-  has_one :user, type: "user", field: :user_id
+  has_one :user, serializer: CodeCorpsWeb.UserSlimView, include: true
 end

Diff for: lib/code_corps_web/views/project_view.ex

@@ -14,14 +14,14 @@ defmodule CodeCorpsWeb.ProjectView do
     :total_monthly_donated, :updated_at, :website
   ]
 
-  has_one :organization, type: "organization", field: :organization_id
+  has_one :organization, serializer: CodeCorpsWeb.OrganizationView, include: true
   has_one :stripe_connect_plan, serializer: CodeCorpsWeb.StripeConnectPlanView
 
   has_many :donation_goals, serializer: CodeCorpsWeb.DonationGoalView, identifiers: :always
   has_many :project_categories, serializer: CodeCorpsWeb.ProjectCategoryView, identifiers: :always
   has_many :project_github_repos, serializer: CodeCorpsWeb.ProjectGithubRepoView, identifiers: :always
   has_many :project_skills, serializer: CodeCorpsWeb.ProjectSkillView, identifiers: :always
-  has_many :project_users, serializer: CodeCorpsWeb.ProjectUserView, identifiers: :always
+  has_many :project_users, serializer: CodeCorpsWeb.ProjectUserView, include: true
   has_many :tasks, serializer: CodeCorpsWeb.TaskView, identifiers: :always
   has_many :task_lists, serializer: CodeCorpsWeb.TaskListView, identifiers: :always
 

Diff for: lib/code_corps_web/views/task_view.ex

@@ -13,8 +13,8 @@ defmodule CodeCorpsWeb.TaskView do
   has_one :github_repo, type: "github-repo", field: :github_repo_id
   has_one :project, type: "project", field: :project_id
   has_one :task_list, type: "task-list", field: :task_list_id
-  has_one :user, type: "user", field: :user_id
-  has_one :user_task, serializer: CodeCorpsWeb.UserTaskView, identifiers: :always
+  has_one :user, serializer: CodeCorpsWeb.UserSlimView, include: true
+  has_one :user_task, serializer: CodeCorpsWeb.UserTaskView, include: true
 
   has_many :comments, serializer: CodeCorpsWeb.CommentView, identifiers: :always
   has_many :task_skills, serializer: CodeCorpsWeb.TaskSkillView, identifiers: :always

Diff for: lib/code_corps_web/views/user_slim_view.ex

@@ -0,0 +1,57 @@
+defmodule CodeCorpsWeb.UserSlimView do
+  @moduledoc false
+  alias CodeCorps.Presenters.ImagePresenter
+
+  use CodeCorpsWeb, :view
+  use JaSerializer.PhoenixView
+
+  def type, do: "user"
+
+  attributes [
+    :biography, :cloudinary_public_id, :email, :first_name,
+    :github_avatar_url, :github_id, :github_username, :intercom_user_hash,
+    :inserted_at, :last_name, :name, :photo_large_url, :photo_thumb_url,
+    :sign_up_context, :state, :state_transition, :twitter, :username,
+    :website, :updated_at
+  ]
+
+  def photo_large_url(user, _conn), do: ImagePresenter.large(user)
+
+  def photo_thumb_url(user, _conn), do: ImagePresenter.thumbnail(user)
+
+  @doc """
+  Returns the user email or an empty string, depending on the user
+  being rendered is the authenticated user, or some other user.
+
+  Users can only see their own emails. Everyone else's are private.
+  """
+  def email(user, %Plug.Conn{assigns: %{current_user: current_user}}) do
+    if user.id == current_user.id, do: user.email, else: ""
+  end
+  def email(_user, _conn), do: ""
+
+  @intercom_secret_key Application.get_env(:code_corps, :intercom_identity_secret_key) || "RANDOM_KEY"
+
+  def intercom_user_hash(%{id: id}, _conn) when is_number(id) do
+    id |> Integer.to_string |> do_intercom_user_hash
+  end
+  # def intercom_user_hash(_user, _conn), do: nil
+
+  defp do_intercom_user_hash(id_string) do
+    :crypto.hmac(:sha256, @intercom_secret_key, id_string)
+    |> Base.encode16
+    |> String.downcase
+  end
+
+  @doc """
+  Returns the user's full name when both first and last name are present.
+  Returns the only user's first name or last name when the other is missing,
+  otherwise returns nil.
+  """
+  def name(%{first_name: first_name, last_name: last_name}, _conn) do
+    "#{first_name} #{last_name}" |> String.trim |> normalize_name
+  end
+
+  defp normalize_name(name) when name in ["", nil], do: nil
+  defp normalize_name(name), do: name
+end

Diff for: lib/code_corps_web/views/user_task_view.ex

@@ -4,5 +4,5 @@ defmodule CodeCorpsWeb.UserTaskView do
   use JaSerializer.PhoenixView
 
   has_one :task, type: "task", field: :task_id
-  has_one :user, type: "user", field: :user_id
+  has_one :user, serializer: CodeCorpsWeb.UserSlimView, include: true
 end