Skip to content

Commit 810cc30

Browse files
authored
Merge pull request #1346 from code-corps/fix-project-user-issue
Fix project user response
2 parents 166ff1a + 70ff403 commit 810cc30

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/code_corps_web/controllers/project_user_controller.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ defmodule CodeCorpsWeb.ProjectUserController do
4343
{:ok, %ProjectUser{} = updated_project_user} <- project_user |> ProjectUser.update_changeset(params) |> Repo.update,
4444
_ <- maybe_send_update_email(updated_project_user, project_user)
4545
do
46-
conn |> render("show.json-api", data: project_user)
46+
conn |> render("show.json-api", data: updated_project_user)
4747
end
4848
end
4949

test/lib/code_corps_web/controllers/project_user_controller_test.exs

+4-3
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
22
use CodeCorpsWeb.ApiCase, resource_name: :project_user
33
use Bamboo.Test
44

5-
@attrs %{role: "contributor"}
6-
75
describe "index" do
86
test "lists all resources", %{conn: conn} do
97
[record_1, record_2] = insert_pair(:project_user)
@@ -102,7 +100,10 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
102100
record = insert(:project_user, project: project, role: "pending")
103101
insert(:project_user, project: project, user: current_user, role: "owner")
104102

105-
assert conn |> request_update(record, @attrs) |> json_response(200)
103+
params = %{role: "contributor"}
104+
json = conn |> request_update(record, params) |> json_response(200)
105+
106+
assert json["data"]["attributes"]["role"] == "contributor"
106107

107108
user_id = current_user.id
108109

0 commit comments

Comments
 (0)